Giter Club home page Giter Club logo

Comments (2)

janisz avatar janisz commented on May 18, 2024

Hi @tsaridas

It's good idea to make MARATHON_CONSUL_LABEL configurable and add possibility to register all services (e.g. provided config value is empty). Changes are required in AppId.ConsulServiceName and Config.

This issue is related to #81 and could be resolved in same way — MARATHON_CONSUL_LABEL could be provided as a parameter or as a global variable that will be setup at the beginning of main.

from marathon-consul.

janisz avatar janisz commented on May 18, 2024

@tsaridas I think your problem is not related to MARATHON_CONSUL_LABEL. In my opinion it should stay as is. We could add another configuration option to say all services should be registered in Consul. If we add special meaning for empty string in MARTHON_CONSUL_LABEL we will lose ability to change names for single service.

from marathon-consul.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.