Giter Club home page Giter Club logo

Comments (4)

uchuck avatar uchuck commented on May 27, 2024 1

Sure, then I can make a patch and test it.

from bigcache.

janisz avatar janisz commented on May 27, 2024

Looks like we should use uint64 in

hashmap map[uint64]uint32

I think it will be backward compatible change. Would you like to contribute a patch with a test for this case?

from bigcache.

uchuck avatar uchuck commented on May 27, 2024

Looks like we should use uint64 in

hashmap map[uint64]uint32

I think it will be backward compatible change. Would you like to contribute a patch with a test for this case?

I was thinking the same change. However, it could potentially increase the total space of the BigCache in the case if people use it to store a huge number of small entries. The size of entries Queue won't change, but the size of map keys will be doubled. Will this be a concern for the original BigCache design?

from bigcache.

janisz avatar janisz commented on May 27, 2024

That's true. The solution could be to change map type when we hit given threshold.
I'm wondering if this issue is the root cause of #290
Anyway, although change from 32 to 64 bits could double memory overhead I believe this footprint should be small enough that nobody will notice.

from bigcache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.