Giter Club home page Giter Club logo

Comments (9)

adamdubiel avatar adamdubiel commented on May 20, 2024

My testing branch has support for CredentialsProvider - username + passwd via console (which is pain in gradle..). I will take a look at proper config of CredentialsProvider using GH, there might be some jgit magic involved.

from axion-release-plugin.

szpak avatar szpak commented on May 20, 2024

I tried to it with GrGit directly and it seems GrGit itself doesn't support passing credentials via the URL (pushing with jgit directly was too complicated for me and I gave up :) ). I wasn't able to find your testing branch with username/password support, but it would be good that you provide way to pass username and password in the configuration closure - to set it programmatically (from environment variables).

Btw, if you would like to add something more before 1.0.0 maybe it would be good to release 0.9.10 earlier?
Btw2, VersionConfig becomes larger and larger. Maybe (as it is still before 1.0.0) it would be good to move git/repository configuration into a subelement?

from axion-release-plugin.

adamdubiel avatar adamdubiel commented on May 20, 2024

Providing passwords via config closures and interactive mode as just one set of closures is a nice idea, i will implement it. I didnt have time to polish interactive mode last week, but i will push the branch to remote. I could use some more testing on this one - think you could help me out? I can't tell if it will behave nicely on different kinds of terminals.

from axion-release-plugin.

szpak avatar szpak commented on May 20, 2024

Some time ago I did simple asking about passphase for PGP key in my plugin, but it requires to run in non demon mode. In the meantime I have seen a solution which works also from daemon (I can try to find it again). I don't know if it could be automatic tested in the reliable way.

Btw, yesterday when I was working on NPE with jgit I discovered that GrGit has quite nice support for authorization. It supports SSH agent, pyagent from Putty (unfortunately no Gnome keyring) and interactive asking in a platform specific way (on Linux there is a small Swing window). I haven't tested, but maybe when X server is not available a question on the console is used? Maybe it could be reused in some way?

from axion-release-plugin.

adamdubiel avatar adamdubiel commented on May 20, 2024

I think i will get involved in grgit devlopment more, because it feels like were doing stuff that could be used by more people if it was exposed in library like grgit. I will leave this open past 1.0.0.

Or maybe there's place for some general-purpose java jgit wrapper library, because it's a pity grgit is so groovy/gradle centric. Can't say i have much time for this kind of involvement though :P

from axion-release-plugin.

adamdubiel avatar adamdubiel commented on May 20, 2024

I came to revisit this issue, as i had some need for Basic Auth/GitHub tokens :) I did not like passing GH Token via system variables (Grgit way), so i made own, simple implementation consistent with already present ssh keys supports. Usage is simple and straightforward:

./gradlew release -Prelease.customUsername=<myGithubCode>

Just be sure to checkout repository as https://github.com/..., without any codes inside. Documentation is also present.

from axion-release-plugin.

szpak avatar szpak commented on May 20, 2024

Sounds ok. Secure variables are masked in Travis and in addition probably release.customPassword could be also set within a build script (like dryRun).

from axion-release-plugin.

szpak avatar szpak commented on May 20, 2024

Btw, you have a wrong milestone for that issues - 1.0.1.

from axion-release-plugin.

adamdubiel avatar adamdubiel commented on May 20, 2024

Exactly, it can be set in runtime (see the docs).

from axion-release-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.