Comments (2)
Do you propose this would be as a replacement for or an addition to the current parsing method we have? If there is a particular feature we wish to add such as breaking up strings into substrings, might it be better to implement that within our own framework than absorb an extra dependency? That particular feature does not seem an insurmountable challenge. On the other hand, we could probably simplify our own code substantially while improving its feature set by switching to marquee.
Interestingly, marquee uses a custom C++ tokenizer and parser stack to process the markdown, very similar to the mechanism I have used myself for pdf parsing, and close to what I envisaged we could write when rich text support was first discussed back in #39. I think we had decided against it because compiled code would be too bothersome to maintain. I'm glad a more feature-filled version is available to use now (and maintained by someone else!)
from geomtextpath.
For now, I'll propose this as an addition to the current rich text parsing and maybe start gradually deprecating the current method over time. I'm willing to put {marquee} into the suggested packages in order to not maintain a parser. If {gridtext} had exported their parser, I think I had preferred to use that too; but since they didn't, we had to copy it. I'm still convinced that I wouldn't be able to maintain a C++ parser :p
I'll have to figure out exactly how it'll work but my initial feel for this feature would be that we could pass e.g. richtext = marquee::classic_style()
(or another style set) and then {geomtextpath} would know to use marquee parsing.
from geomtextpath.
Related Issues (20)
- Partial match of 'xoff' to 'xoffset'
- geom_textsf seems to ignore remove_long=F
- Long labels with arrow throw cryptic "Error: Cannot create zero-length unit vector ("unit" subsetting)" error
- Strange behaviour of halign HOT 4
- Feature Request: Set angle for geom_labelvline HOT 6
- Feature request - test for text self-overlap on sharp contours HOT 1
- ggplot coord_polar() issue with multiple classes: 'from' must be a finite number error HOT 1
- session aborted when library in Rstudio HOT 2
- Add compatibility with `ggbump` HOT 2
- geom_textsf randomly throws erros when specification of font family is missing (OpenSUSE Leap 15.5, R 4.3.2) HOT 2
- Release geomtextpath 0.1.2 HOT 1
- library(geomtextpath) abort the R session HOT 2
- Prevent rounding of numeric labels HOT 2
- geomtextpath example code does not seem to work HOT 6
- Warning messages: "All aesthetics have length 1, but the data has XX rows" HOT 2
- Issues with the upcoming version of textshaping HOT 3
- geomtextpath fails CRAN check HOT 13
- Release geomtextpath 0.1.4 HOT 9
- 0.1.4 release line breaks not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geomtextpath.