Giter Club home page Giter Club logo

Comments (1)

gabor-farkas avatar gabor-farkas commented on August 26, 2024

To put the short story long: to save memory and space and time, the title of a Tab is a single String, not a full-fledged dsweb component extending BaseComponentModel, thus it doesn't automatically inherit all the functionality that the BaseComponent class provides. This is similar to DataTable headers for example.
But, as this issue also shows, requirements emerge from time-to-time to add specific features from BaseComponent to these special labels as well. Stuff like this is seriously painful in the current dsweb architecture, because we have to repeat code over and over special stuff like this.

My proposal for now is somewhat similar to the case of datatable cells that can be single strings or full components (that still doesn't allow the creator of the View to work with the TR and TD elements).

  • Extend the Tab class with a BaseComponentModel titleComponent field.
  • Extend it with a withTitleComponent(HasComponentModel titleComponent) method that sets this field. This component is required to render as an LI element. This has to be asserted in the Renderer and an exception is to be thrown if not fulfilled.
  • Extend the TabSheetRenderer to properly handle this field. Of course, exactly one of title and titleComponent are not null. If the component field is set, the renderer won't create the LI element itself, but it will rely on the given element. The clickhandler is attached anyway.
  • TabSheetRenderer should react to any change in these fields and update the view accordingly

This solution will allow any kind of customization of the tab caption.

Please don't forget the GwtTestCase-es :)

from dsweb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.