Giter Club home page Giter Club logo

Comments (2)

alitto avatar alitto commented on May 14, 2024

Hey @zhu121,

The reason the mutex lock is needed there is to prevent decrementWorkerCount decreasing the workerCount variable while this block is executed in incrementWorkerCount, which could bring undesirable consequences, such as adding more workers than necessary or not starting new ones when needed. And for this to happen, the runningWorkerCount variable in that block must reflect the actual number of worker goroutines during the entirety of the block. A similar thing could happen if incrementWorkerCount was executed simultaneously from 2 different threads.
Does it make sense?

from pond.

zhu121 avatar zhu121 commented on May 14, 2024

Hey @zhu121,

The reason the mutex lock is needed there is to prevent decrementWorkerCount decreasing the workerCount variable while this block is executed in incrementWorkerCount, which could bring undesirable consequences, such as adding more workers than necessary or not starting new ones when needed. And for this to happen, the runningWorkerCount variable in that block must reflect the actual number of worker goroutines during the entirety of the block. A similar thing could happen if incrementWorkerCount was executed simultaneously from 2 different threads. Does it make sense?

Hey @alitto, thank you for your reply, I understand it

from pond.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.