Comments (9)
clement-leprovost
commented on July 21, 2024
1
@TofPlay Then I encourage you to watch issue #74 (Swift 2.3/3.0 support).
from algoliasearch-client-swift.
TofPlay
commented on July 21, 2024
Update: If I try to upload my project to the App Store with Algolia version 3.2.1 Xcode show this message:
from algoliasearch-client-swift.
clement-leprovost
commented on July 21, 2024
@TofPlay Regarding the App Store warning, this is a duplicate of #75 and should have been fixed yesterday.
Tip: try explicitly using master HEAD, otherwise Carthage will likely pick up the last released version, which does not contain this fix. A new release is planned, but we have other pending changes to ship, so it is not yet available.
from algoliasearch-client-swift.
TofPlay
commented on July 21, 2024
@clement-leprovost with the master branch that generate a couple of warnings:
Cartfile
github "algolia/algoliasearch-client-swift" "master"
Cartage Output
$ carthage update --platform iOS
*** Cloning algoliasearch-client-swift
*** Checking out algoliasearch-client-swift at "ab140efdc3ea41072b079427031ea4ac4f080eb5"
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:87:12: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
/Carthage/Checkouts/algoliasearch-client-swift/Source/Request.swift:96:16: warning: unnecessary check for 'iOSApplicationExtension'; minimum deployment target ensures guard will always be true
from algoliasearch-client-swift.
clement-leprovost
commented on July 21, 2024
Yes, that's expected (as explained in #75). We cannot avoid those warnings, as the source code is compatible with iOS 7 (as requested in #62), but package managers like Carthage and CocoaPods build dynamic frameworks that are only supported on iOS 8.
from algoliasearch-client-swift.
TofPlay
commented on July 21, 2024
That strange because with version 2.3 I don't have those warnings
from algoliasearch-client-swift.
TofPlay
commented on July 21, 2024
With the branch master upload has successfully completed 👍
Thanks @clement-leprovost for your support 🙂
from algoliasearch-client-swift.
clement-leprovost
commented on July 21, 2024
@TofPlay You're welcome! Glad to know you're back on track. :)
Regarding version 2.3, it's normal that you didn't get the warnings: minimum OS version was 7.0, so the runtime check was legitimate. Again, this whole thing is a compromise: we can't both support iOS 7 in the source code and allow building dynamic frameworks and avoid the warnings...
from algoliasearch-client-swift.
TofPlay
commented on July 21, 2024
Version 2.3 I also use it as a dynamic framework with Carthage for our application in iOS 8
Anyway I'm much more interested about a support of Swift 3 for Algolia. 😊
from algoliasearch-client-swift.
Related Issues (20)
- Ensure the support of A/B tests related fields in the search response
- SearchClient.multipleQueries() does not return queryID in SearchResponse objects HOT 1
- feat(query): missing enableReRanking field
- Facet values order is not preserved HOT 1
- Algolia's use of custom operators clashes with custom operators defined in applications that consume this library HOT 3
- Error 400 when Around Precision property is assigned HOT 4
- Error 494 Header Too Large with some API Keys HOT 4
- Crash - AlgoliaSearchClient: protocol witness for Decodable.init(from:) in conformance JSON + 20 HOT 3
- Issue with query string containing & char HOT 1
- Naming clash with Swift's Task HOT 4
- Facet values with certain characters don't work HOT 2
- Client side error handling
- index.getObject() does not work with full Shopify ID
- refactor `extension URLSession: HTTPRequester`
- Reporting a vulnerability
- ThreadSanitizer: data race
- Dependency Dashboard
- Match JS library - Fetch Recommendations Using an Array of Object ID's
- Apple Privacy Manifest File HOT 5
- 8.20.0 upgrade prevents project from building HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from algoliasearch-client-swift.