Giter Club home page Giter Club logo

Comments (4)

lolgesten avatar lolgesten commented on July 26, 2024

Yes. This would be a really nice feature. I'm not entirely sure how one would implement it though. It's like the timeouts in TCP connection/read/write must be adjusted dynamically from some start time, and then top it off with closing the connection if it goes on too long.

from ureq.

Shnatsel avatar Shnatsel commented on July 26, 2024

You could compute a request deadline (or let the user explicitly specify it, there is an opinion that deadlines are the better API) and then set the read timeout to min(read_timeout, time_until_request_deadline) every once in a while. Doing so on every read is probably wasteful, but doing no more frequently than once in e.g. 250 milliseconds should be precise enough and have a small enough performance hit.

from ureq.

Shnatsel avatar Shnatsel commented on July 26, 2024

A simple implementation of a timeout for the entire request can be viewed here: neonmoe/minreq@41ef16e
However, if used as-is it may have a significant performance penalty.

from ureq.

Shnatsel avatar Shnatsel commented on July 26, 2024

Here's another way of accomplishing this: sbstp/attohttpc#47

from ureq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.