PR #1081 does not fully fix type errors about alfresco-js-api HOT 6 CLOSED

Ts file should not be present I agree, I will give it a look

from alfresco-js-api.

Just tested with v4.4.0 and the package types are still broken. Since this is a critical blocking issue, but easy to fix (see #1110), we will republish until there is an official fix.

Update: In case someone else is having typescript errors with v4.4.0, this version has the necessary fix. If you are not having typescript issues, please use the official version.

from alfresco-js-api.

Since the current fix #1113 (removing ts files) is another way of solving #1074, it looks like the changes from #1081 became unnecessary and might be reverted.

Compile-time file resolution should work fine when .js and .d.ts files are placed in the same folder, the problem was only when both .ts, .js and .d.ts are in the same folder.

from alfresco-js-api.

@garth to unblock myself, I used the following postinstall script to remove all .ts (but not .d.ts) files:

package.json

"scripts": {
    "postinstall": "node tools/js-api-fix.js",
}

tools/js-api-fix.js

const glob = require('glob');
const fs = require('fs');

glob('node_modules/@alfresco/js-api/**/!(*.d).ts', (err, files) => {
    if (err) throw err;

    console.log(`Fix @alfresco/js-api package issue: https://github.com/Alfresco/alfresco-js-api/issues/1074`);
    console.log(`Remove ${files.length} *.ts files from directory configured only for typings`);

    files.forEach(file => {
        console.log(`remove "${file}"`);
        fs.unlinkSync(file);
    });
});

Hope it helps

from alfresco-js-api.

@Den-dp, I ran a yarn linked local version for a week or so which was OK for local development, but that was only a very temporary solution. I am now using a variant of 4.4 (linked above) with #1110 PR included. So no need for any post install scripts and all typescript errors are gone.

from alfresco-js-api.

Fixed with the latest builds

from alfresco-js-api.