Giter Club home page Giter Club logo

Comments (15)

draperd avatar draperd commented on September 2, 2024

Thanks the feedback - it's greatly appreciated and I'm glad you've found the tutorial useful.

With regards to the width, since Aikau 1.0.31 it is now possible to configure a "maxWidth" attribute on the alfresco/renderers/Property (and therefore any widgets that inherit from it) that can be used to apply an ellipsis to long values (see http://dev.alfresco.com/resource/docs/aikau-jsdoc/Property.html).

This won't happen automatically unfortunately (i.e. it won't automatically detect when a value is too long) so you'll need to configure a value.

However, you're probably right that the ClassicWindow should use scrollbars on overflow (or should be configured to do so). I'll raise a bug to get that fixed.

Thanks again.

from aikau.

draperd avatar draperd commented on September 2, 2024

I've raised https://issues.alfresco.com/jira/browse/AKU-644 and it's in the provisional plan for inclusion in our next sprint.

from aikau.

aviriel avatar aviriel commented on September 2, 2024

Thank you!
Then I want to add here info about one more "bug" in the tutorial:
Tutorial16, step 5. It does not work without adding "strict: false" to the visibility config. If it's an expected behaviour, then can you update the tutorial?

from aikau.

draperd avatar draperd commented on September 2, 2024

I think that would be an error in the tutorial - it's possible that the tutorial chapter was written before the changes mentioned here (https://www.alfresco.com/blogs/developer/2014/10/28/aikau-updates-to-dynamic-visibility-config/) ... I'll raise another issue to review and update that tutorial chapter as necessary.

from aikau.

draperd avatar draperd commented on September 2, 2024

I've raised https://issues.alfresco.com/jira/browse/AKU-645 to cover the tutorial investigation/correction.

from aikau.

draperd avatar draperd commented on September 2, 2024

Can you elaborate a bit more on what you think is going wrong with Tutorial 16, step 5... I've tested it out on the latest version of Aikau and it works fine without the strict: false being applied.

The behaviour I'm seeing is that the text field is not initially visible (which is correct) but if you check the checkbox it becomes visible.

Can you describe the behaviour that you're seeing please?

from aikau.

aviriel avatar aviriel commented on September 2, 2024

Tried it again by removing strict:false, and now it works. Sorry for this. I don't know what changed.

from aikau.

draperd avatar draperd commented on September 2, 2024

No problem - thanks for checking again for me... I'm just glad it's working :)

from aikau.

aviriel avatar aviriel commented on September 2, 2024

Then one more question from my side. I know that I become annoying, I don't know is it a problem in a Tutorial or I'm not right again. I owe you a beer in Brussels in April if you'll not ban me because of all my issues :)

Tutorial 17. Step 5
After step 4 I can preview DOCX, PNG, XLS etc, but not PDF ("It has not been possible to load the PDF file"). After adding itemProperty: "", in the beginning of Step 5 I can preview PDF too.

But if I replace:

{
  name: "alfresco/renderers/PropertyLink",
  config: {
    propertyToRender: "node.properties.cm:name",
    publishTopic: "ALF_RETRIEVE_SINGLE_DOCUMENT_REQUEST",
    publishPayloadType: "PROCESS",
    useCurrentItemAsPayload: false,
    publishPayloadModifiers: ["processCurrentItemTokens"],
    publishPayload: {
      nodeRef: "{node.nodeRef}",
      rawData: true
    },                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         
    renderFilter: [
      {
        property: "node.isContainer",
        values: [false]
      }
    ]
  }
}

with

{
  name: "alfresco/renderers/PropertyLink",
  config: {
    propertyToRender: "node.properties.cm:name",
    publishTopic: "ALF_RETRIEVE_SINGLE_DOCUMENT_REQUEST_SUCCESS",
    renderFilter: [
       {
          property: "node.isContainer",
          values: [false]
       }
    ]
  }
}

window with PDFJS disappears.

from aikau.

draperd avatar draperd commented on September 2, 2024

It's no problem answering questions - I'm always very happy to help people as it's useful to understand where there are gaps in the educational material available.

I'll have to step through the tutorial again with the latest version of Aikau to see if anything's changed... I can't see anything obviously wrong, but maybe we've inadvertently introduced a bug - I'll try and get to that later this week.

from aikau.

aviriel avatar aviriel commented on September 2, 2024

Ok, thank you! I met this on Aikau 1.0.39, I started the Tutorial a week ago. I'll try to update to the latest version.

from aikau.

draperd avatar draperd commented on September 2, 2024

If you're on 1.0.39 you should be fine... I meant that we might have broken it since the tutorial was written.

from aikau.

draperd avatar draperd commented on September 2, 2024

You're absolutely right... I've investigated the issue and we appear to have regressed the capabilities of AlfDocument in AKU-233. This has been broken since 1.0.14.

I've raised https://issues.alfresco.com/jira/browse/AKU-656 to address the issue and it will be fixed in the 1.0.42 release. We will add a new unit test to prevent any future regressions.

Thanks for finding this for us.

from aikau.

aviriel avatar aviriel commented on September 2, 2024

Then I completed the Tutorial and don't have any other problems :) You may close the issue.

from aikau.

draperd avatar draperd commented on September 2, 2024

All issues reported in this thread have now been addressed.

from aikau.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.