Comments (3)
I fixed it locally by move this two lines outside of rows loop
callback(false, "Cannot find the specified record."); return;
two lines comment here:
`
for (var i = 0; i < rows.length; i++) {
let matched = 0; // Number of matched complete where clause
for (var j = 0; j < whereKeys.length; j++) {
// Test if there is a matched key with where clause and single row of table
if (rows[i].hasOwnProperty(whereKeys[j])) {
if (rows[i][whereKeys[j]] === where[whereKeys]) {
matched++;
}
}
}
if (matched === whereKeys.length) {
// All field from where clause are present in this particular
// row of the database table
try {
for (var k = 0; k < setKeys.length; k++) {
rows[i][setKeys[k]] = set[setKeys[k]];
}
// Create a new object and pass the rows
let obj = new Object();
obj[tableName] = rows;
// Write the object to json file
try {
jsonfile.writeFile(fname, obj, {spaces: 2}, function (err){
console.log(err);
});
callback(true, "Success!")
return;
} catch (e) {
callback(false, e.toString());
return;
}
callback(true, rows);
} catch (e) {
callback(false, e.toString());
return;
}
} else {
// callback(false, "Cannot find the specified record.");
// return;
}
}`
from electron-db.
Hi there. Thanks for opening the issue. Can you please send a detailed implementation of the unedited electron-db that causes the update method to only work on the first record? I've used it in my apps and they work just fine. So I needed a little more detailed data. Thank you.
from electron-db.
Bug fixed. Hi miladkian, I've fixed the bug issue in updateRow.
By only moving the 2 lines of code you mentioned above will only fix the message.
My mistake was that the whole setting and comparison of every matched key and value were inside the loop, hence the comparison runs at each loop.
Thank you for opening the issue, it helped fixed the problem.
from electron-db.
Related Issues (20)
- BUG - getAll example uses incorrect syntax HOT 3
- UpdateRow Error HOT 1
- Problem app.asar.unpacked HOT 4
- Any way to drop entire table? HOT 2
- specify the documentation of the attributes of each of the functions to have a documentation section HOT 1
- Do this have any db lock/wait feature? HOT 1
- Table exists? HOT 1
- getField should return false for invalid field/key HOT 2
- Typo in variable of valid() function HOT 2
- updateRow updates only 1 row HOT 1
- Feature Request: tableExists method HOT 1
- Feature Request: Allow functions as where statements HOT 3
- i got a problem at getRow(s) HOT 3
- fs.existsSync is not a function HOT 4
- delete function error HOT 1
- [BUG] DeleteRow HOT 2
- Location custom doesn't work when packaging?
- [Feature]- Add unique check during insert and update HOT 2
- Broken Json issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron-db.