Giter Club home page Giter Club logo

Comments (6)

alexisakers avatar alexisakers commented on June 28, 2024 1

Nice idea, I'll be working on this.

from bulletinboard.

jyounus avatar jyounus commented on June 28, 2024 1

How about making the BulletinInterfaceFactory class "open" instead of "public"? This way we could inherit and override it to customise the properties. You'd also have to make the functions (e.g. makeTitleLabel open instead of public) for this to work, as well as change the PageBulletinItem.interfaceFactory from a let to a var property, so it can be changed.

Even better would be if you could use Protocols instead, but may not be something you want to do. It would just make it easier to override existing classes/functionality.

from bulletinboard.

alexisakers avatar alexisakers commented on June 28, 2024 1

@jyounus Using protocols is an excellent idea. I'll work on a PR to implement this.

from bulletinboard.

CaliCastle avatar CaliCastle commented on June 28, 2024

@jyounus You're right, making the class open instead of "public" would a fantastic idea for better inheritance and override availability.

from bulletinboard.

alexisakers avatar alexisakers commented on June 28, 2024

I've made a PR (#26) that implements a better customization API. @CaliCastle @jyounus would you mind telling me if it suits your needs?

from bulletinboard.

alexisakers avatar alexisakers commented on June 28, 2024

Implemented by #26

from bulletinboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.