UX refinements about k3sup HOT 9 CLOSED

You should type in this though? sudo cp k3sup-darwin /usr/local/bin/k3sup

from k3sup.

Worked for me

space-mini:tmp alex$ curl -sLS https://get.k3sup.dev | sh

You already have the k3sup cli!
Overwriting in 1 seconds.. Press Control+C to cancel.

Downloading package https://github.com/alexellis/k3sup/releases/download/0.4.2/k3sup-darwin as /tmp/k3sup-darwin
Download complete.

=========================================================
==    As the script was run as a non-root user the     ==
==    following commands may need to be run manually   ==
=========================================================

  sudo cp k3sup-darwin /usr/local/bin/k3sup

space-mini:tmp alex$   sudo cp k3sup-darwin /usr/local/bin/k3sup
Password:
space-mini:tmp alex$ 

from k3sup.

Yeah, if I follow the instructions it work, but if I just copy and paste the instructions from the README.md, it doesn't:

# Instructions from README.md
curl -sLS https://get.k3sup.dev | sh
sudo install k3sup /usr/local/bin/

k3sup --help

# output

You already have the k3sup cli!
Overwriting in 1 seconds.. Press Control+C to cancel.

Downloading package https://github.com/alexellis/k3sup/releases/download/0.4.2/k3sup-darwin as /Users/jonatasbaldin/scratch/test-k3s/k3sup-darwin
Download complete.

=========================================================
==    As the script was run as a non-root user the     ==
==    following commands may need to be run manually   ==
=========================================================

  sudo cp k3sup-darwin /usr/local/bin/k3sup

Password:
install: k3sup: No such file or directory

The second line from the README instruction fails.

from k3sup.

This is the normal way to download with the suffix still in-tact, but if you want, we could change it. I'd accept a �PR

from k3sup.

The point was to show one example of how to install, the example in the README is for Linux where there is no suffix, you're using Darwin, so you need to follow the output instead :-)

from k3sup.

I can make a PR, I have three ideas (in the order that I most like them):

1. Remove second line from README.md and add sudo before the first line, will always work
2. Remove second line from README.md, let the user read the instructions
3. Change the get.sh script to download the file as k3sup instead of k3sup-$suffix

What do u think?

from k3sup.

I think 3. sounds fine, if you'd like to implement it.

from k3sup.

/set title: UX refinements

from k3sup.

Went with 3 :D

from k3sup.