Giter Club home page Giter Club logo

Comments (5)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024
I did a search on the xls (more than 6000 rows) , none of the fields has a '!' 
except in the column with the chines translation and characters. 

Original comment by [email protected] on 6 Oct 2011 at 11:07

from i18n-binder.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024
easy to fix:
line 71 in PropertyFileContentParser is:
Pattern patternComment = Pattern.compile( "([^\\#]*)(\\!|\\#)(.*)" );
but should be: 
Pattern patternComment = Pattern.compile("([\\s]*)(\\!|\\#)(.*)");
according to 
http://download.oracle.com/javase/7/docs/api/java/util/Properties.html:
 "A comment line has an ASCII '#' or '!' as its first non-white space character"

Original comment by [email protected] on 14 Oct 2011 at 6:05

from i18n-binder.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024
Thanks for your additional mail, it made me recongnize the issue. 

You are completly right, the line you pointed out should be fixed like this. I 
will fix it as soon as possible.

Original comment by [email protected] on 14 Oct 2011 at 7:35

from i18n-binder.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024
Fixed this issue with 0.1.3 release

Can you please verify?

Original comment by [email protected] on 14 Oct 2011 at 10:05

  • Changed state: Fixed

from i18n-binder.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024
Had to change the above code again. Now I remembered why the pattern of a 
comment could not only beginn with spaces: the BOM of UTF-8 encoded files can 
be read in at the first line, and if the first line is a comment line it fails.

I changed it now to 
Pattern patternComment = Pattern.compile( "([^\\:\\=]{0,4}[\\s]*)(\\!|\\#)(.*)" 
);

which should apply fine, even if not perfectly what the spec says.

Original comment by [email protected] on 6 Nov 2011 at 9:04

from i18n-binder.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.