Giter Club home page Giter Club logo

Comments (2)

Janiczek avatar Janiczek commented on June 25, 2024 1

No, I don't suggest changing the names, even though overlay gives a little bit more intuition about not adding any edges. I think union and product are mostly fine, just that the documentation could say / show that it doesn't add / does add edges, and how.

from elm-algebraic-graph.

alexandrepiveteau avatar alexandrepiveteau commented on June 25, 2024

Hi !
Thanks for the suggestion. I do plan to improve the documentation a bit in the coming weeks (or maybe next month, I have some college exams soon), especially by adding some code examples for the different library functions that show their effects better.

The point you raise is interesting – do you think that using union and product is not appropriate in this context, and that the library should switch to the original paper terminology with overlay and connect ? I originally thought that union would be consistent with Elm core's Set.union, and that product would remind the user of Cartesian products.

This is definitely a question that requires an answer before the next major release though, so we can integrate an breaking change to use better naming conventions. Thanks for pointing that out !

from elm-algebraic-graph.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.