Custom styles randomically neglected about save-as-ebook HOT 6 OPEN

Hi Adam, there is something in your code that I really don't get...possibly related to this issue.

In file extractHtml.js, it looks like lines 329-335 (which are related to the custom styles) are never executed...

from save-as-ebook.

It looks like Chrome is not affected...only Firefox

from save-as-ebook.

hmm... that's the 'else' of the "Include (Custom) Style" check on the menu. it's a mess, I'll take a look on it

from save-as-ebook.

I see, I've tried to follow your code execution...and I think I found the bug.

I guess the problem is when you inject the custom css style in the page (chrome.tabs.insertCSS line 273 in background.js), you should wait until the operation is completed (in fact, the method accepts a callback, both in Firefox and Chrome, despite what is written in Firefox docs).

At the moment, you're not waiting - and probably this causes the issue in Firefox.

Anyway, I kindly suggest you to refactor your code in a more functional style, using map, filter, reduce to get rid of the for cycles, possibly resorting to a linter in order to mantain a strict adherence to a particular coding style and employing an asynchronous library, such as parseq (https://github.com/douglascrockford/parseq) or similar to remove all the callbacks. And you should remove the function parameters that are unused.

oh, and put the libraries you're using (jquery, etc.) in a lib folder or similar.

from save-as-ebook.

I fixed it, thanks for the help!

from save-as-ebook.

Very good!

from save-as-ebook.