Comments (6)
Hi Adam, there is something in your code that I really don't get...possibly related to this issue.
In file extractHtml.js, it looks like lines 329-335 (which are related to the custom styles) are never executed...
from save-as-ebook.
It looks like Chrome is not affected...only Firefox
from save-as-ebook.
hmm... that's the 'else' of the "Include (Custom) Style" check on the menu. it's a mess, I'll take a look on it
from save-as-ebook.
I see, I've tried to follow your code execution...and I think I found the bug.
I guess the problem is when you inject the custom css style in the page (chrome.tabs.insertCSS line 273 in background.js), you should wait until the operation is completed (in fact, the method accepts a callback, both in Firefox and Chrome, despite what is written in Firefox docs).
At the moment, you're not waiting - and probably this causes the issue in Firefox.
Anyway, I kindly suggest you to refactor your code in a more functional style, using map, filter, reduce to get rid of the for cycles, possibly resorting to a linter in order to mantain a strict adherence to a particular coding style and employing an asynchronous library, such as parseq (https://github.com/douglascrockford/parseq) or similar to remove all the callbacks. And you should remove the function parameters that are unused.
oh, and put the libraries you're using (jquery, etc.) in a lib folder or similar.
from save-as-ebook.
I fixed it, thanks for the help!
from save-as-ebook.
Very good!
from save-as-ebook.
Related Issues (20)
- Capturing unneeded elements HOT 4
- Some minor grievances. HOT 2
- All saved EPUB have identical identifier
- Support defining title, author and cover HOT 1
- Need more control over the capture HOT 3
- Feature Request: Add all tabs as Chapters HOT 1
- request to get it work for thunderbird HOT 1
- Feature Request: extract H1,H2,etc. tags as chapters HOT 2
- display block missing in some classes HOT 1
- Table borders are not present in the ePub HOT 2
- replacing iframes with divs - issue concerning inline styles
- Ruby rb tags ignored by extractHtml.js HOT 1
- Feature request - button to change page direction of ebook HOT 1
- Unexpected behavior on custom stylesheet. HOT 1
- Parse error - o:p tag I think HOT 1
- Congrats on 1001 stars! HOT 1
- Images?
- Ruby rp tags dropped by extractCss() of extractHtml.js
- Doesn't work in Reader Mode HOT 3
- Website pictures are not included on the protected websites HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from save-as-ebook.