Comments (7)
Can you try to modify your MyMap.js
to :
<ZoomControl
zoomDiff={1}
onControlClick={this._onControlClick.bind(this)}
/>
from react-mapbox-gl.
That doesn't help. It just adds a new warning:
Warning: bind(): You are binding a component method to the component. React does this for you automatically in a high-performance way, so you can safely remove this call. See AlvarMap
The warning comes because ZoomControl component is messing with MyMap component's method.
zoom-control.js, row 103:
onClick={onControlClick.bind(this, map, zoomDiff)}>
There the onControlClick
method is MyMap's method: MyMap._onControlClick
. React warns because you shouldn't be rebinding the this
to a new component.
from react-mapbox-gl.
I have published a patch (0.19.1
) where I have replaced the bind with an arrow function, let me know if it fix your issue.
from react-mapbox-gl.
I tested with version 0.19.1 but the problem still persists.
from react-mapbox-gl.
Can you send me a link to your project ? or a link to a jsfiddle ?
from react-mapbox-gl.
The affected line was changed in a previous patch and we don't have an example available, to reproduce the issue, thus I need to close this for now 😄
from react-mapbox-gl.
Sorry for taking so long. I don't know how I tested it before but I can now confirm that bump from 0.18.0 -> 0.19.1 fixed this issue.
A reproducible example of the bug: https://github.com/kimmobrunfeldt/react-mapbox-gl-bug/blob/master/src/MyMap.js
git clone [email protected]:kimmobrunfeldt/react-mapbox-gl-bug.git
cd react-mapbox-gl-bug
npm install
npm start
from react-mapbox-gl.
Related Issues (20)
- Invalid LngLat object error when zooming on markers
- Example needed: OpenStreetmap Example without Mapbox accessToken
- DrawControl in React v18 and above
- ultra-weird bug : some images don't show up on mobile devices (works fine on desktop computer) HOT 2
- React v18: Map container is being appended to DOM twice
- Renders black screen after multiple renders. HOT 1
- Popup missing `closeOnClick` prop
- Control Feature fade in animation
- Markers wiggle on React 18 HOT 6
- Cluster Marker disappearing when zoom screen with 70%, 80%
- Cannot assign to import "accessToken" error on Remix HOT 5
- [HELP] MapboxMap - how to use onLoad to switch displayed language of map?
- Layers do not renderer HOT 2
- ReactMapGL not showing after deploying, buit during development it is working perfectly HOT 1
- Is GL JS v3 supported ? HOT 1
- add open-ended option overrides in constructor
- Features not showing
- WebpackError: TypeError: _layer_events_hoc__WEBPACK_IMPORTED_MODULE_1___defaul t(...) is not a function HOT 1
- Feature coordinates not adjusting to new variables. HOT 1
- Peer dependencies HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-mapbox-gl.