Compile mapbox-gl-js using webpack about react-mapbox-gl HOT 12 CLOSED

@DominikLevitsky Currently on it @philpl is helping on this 👍

from react-mapbox-gl.

https://github.com/mapbox/mapbox-gl-js#using-mapbox-gl-js-with-webpack

from react-mapbox-gl.

The precompiled file caused issues for me running a universal app (was complaining window not being available on server side).

I simply cloned the repo and switched the imports to "mapbox-gl", and now it works just fine. (I already had the necessary webpack config in place).

from react-mapbox-gl.

Hi @PrebenL, thanks for reporting this issue, i haven't really spend lot of time on this as it was just a warning but i didn't know that the pre-compiled version is failing when doing a server side rendering of the component.

I will have a look as soon as possible.

from react-mapbox-gl.

https://github.com/alex3165/react-mapbox-gl/pull/25/files

from react-mapbox-gl.

As to the exact why, I don't know either, but I think somewhere in the "mapbox-gl" library there is some kind of dynamic switching, allowing the "gl" library (also known as headless gl), to take over when you're on an environment where window / web-gl is not available (i.e. server).

from react-mapbox-gl.

Hey, any updates on this? Would be really cool to have this fixed.

from react-mapbox-gl.

@alex3165 react-mapbox-gl references https://github.com/mapbox/mapbox-gl-js/blob/master/js/util/browser/browser.js when I believe it should reference the headless version https://github.com/mapbox/mapbox-gl-js/blob/master/js/util/browser.js?

from react-mapbox-gl.

@alex3165 Hi. Any chances for us to get an update in the next couple of days? :)

from react-mapbox-gl.

@DominikLevitsky I will give you an update by the end of the week-end and hopefully come up with a solution :)

from react-mapbox-gl.

So now mapbox-gl-js is compiled using Webpack see #43. I think it will still not be possible to render on the server side though because the library is using web worker for some operation and this won't work in a nodejs environment.

from react-mapbox-gl.

It's very hard to determine how to "make the switch" to the mocked browser of mapbox-gl. I think technically it's not hard to switch it around, but it's hard to determine, whether React is being rendered in a server-side context. If someone has input on that, I'd appreciate it.

Edit: Actually since we're precompiling mapbox-gl as a vendor bundle, there might still be code present, that is responsible for the switch. @PrebenL, you might have more information and are able to test whether it works? The version with the change is 0.10

from react-mapbox-gl.