Add search bar about hugo-book HOT 14 CLOSED

from hugo-book.

Hi!
I suppose it's due to title not being jsonified as well here: https://github.com/alex-shpak/hugo-book/blob/master/assets/search-data.js#L8

Can you please check place where error given and post it here? Or if your website is public to share a link so I can check it.

Edit: I pushed changes to master, please try now.

from hugo-book.

Changes are now pushed to master
https://raw.githubusercontent.com/alex-shpak/hugo-book/master/images/screenshot.png

Though, there is still room for improvement in future.

from hugo-book.

Hi!
Yes, it would be nice to have, so far I didn't develop vision on best way implementing this, so It's in TODO state.

from hugo-book.

Work is started at feature/search branch

from hugo-book.

Now I consider two options:

• Keep search bar under site title, and load index on first focus
• Create separate page /docs/search to keep all search functionality, to not load lunr and index on each page.

🤔

from hugo-book.

I'm getting these errors when typing into search bar. Happening in Firefox and Chrome.

Do you know what could be wrong? Thanks.

from hugo-book.

Works flawlessly now! Thank you for a quick fix :)

from hugo-book.

Funnily enough, I ended up setting this up myself from the Hugo Search doc: https://gist.github.com/eddiewebb/735feb48f50f0ddd65ae5606a1cb41ae

Also, the search on the live demo here doesn’t seem to work? It’s got a readonly attribute.

https://themes.gohugo.io/theme/hugo-book/

from hugo-book.

Hi Alex,
first of all thank you very much for your excellent work.

I am using tags and categories for my documents and find in the search results links to list pages for categories and tags. So far this is fine. Unfortunately I find after creation of the site in the category and tag folders only xml files but no html files for the category/tag pages. Would it be possible to enhance the theme with the ability to create those pages too?

Furthermore if I could have some more wishes: It would be great if the single pages could append a footer with a table or an unordered list with two bullets. One for categories and one for tags showing the assigened terms as a comma separated and linked list? Finally it would be a great improvement to the search results, when links to category/tag pages could be distinguished from content pages by a marker or label.

from hugo-book.

@jog968 Hi! Thanks,
I think It would be reasonable to create these feature requests as separate issues in github.

In general, main goal of theme is documentation so I added minimal blogging features, but I would say adding tags and categories is ok. Not top priority tho. PRs are welcome :)

On lists with tags and categories, I think it's too specific feature for generic website, I think better is to customize your footer partial and add what you want.

from hugo-book.

@mistermantas Regarding search on themes.gohugo.io, this is absURL issue, I try to avoid absURL in theme, but they are required there because each theme is subfolder.

Not sure that I want to introduce absolute link to fix that 🤔

from hugo-book.

@alex-shpak: Hi and Thanks,
I'm glad to hear that tags and categories can be added. Priority is not so important. I will wait.

Regarding lists I will try to do this by myself. It is time for me to learn some basics.

from hugo-book.

Closing this issue.

from hugo-book.