When launching alephium wallet a second time on Windows, it offers option to import/start new wallet about desktop-wallet HOT 11 CLOSED

Hi @diomark, thanks for the feedback. Which version of Windows are you using?

When you say that the wallet was running in the background, do you mean that there was a window open and hidden behind other windows? Or that all windows of the application were closed and the process was still running in the background?

Was this the screen you saw when you opened the application the second time, after already creating a wallet?

Thanks a lot for the valuable feedback!

from desktop-wallet.

@nop33 @mvaivre is this related to our latest fix PR? If so, we need to assign a bounty for this issue report

from desktop-wallet.

I haven't been able to reproduce this on my macbook, waiting for input from @diomark. I can check with @Arbaba who is using Windows, when I see him on Friday.

from desktop-wallet.

Windows 10 [Version 10.0.19043.1348]

The existing wallet window was just hiding behind other windows (i.e. functioning correctly/not crashed)

This is pretty easy to replicate -

Start alephium wallet, login

Start alephium wallet again (from start menu. It will give the options of new wallet or importing wallet (vs just focusing on the already opened wallet)

from desktop-wallet.

btw - yes - that's the screen that shows up when launching a second time. (option for new wallet or importing)

from desktop-wallet.

I managed to reproduce the issue. I still haven't found a solution. Some notes during my debugging:

• We create new windows only when 2 events get triggered: ready and activate.
• Even when commenting out the callback of the activate event completely, when clicking the installed Windows Alephium app it still opens a second window. The only place where createWindow is now called is in the ready event callback. Updating the callback to the following snippet does not solve the problem (second window opens again):

  app.on('ready', () => {
    if (mainWindow === null) createWindow()
  })

• I tried this, also no success:

  app.on('ready', () => {
    if (BrowserWindow.getAllWindows().length === 0) createWindow()
  })

• I tried updating the snippet to the following, again, without success:

  app.whenReady().then(() => {
    if (mainWindow === null) createWindow()
  })

• It would seem that every time the installed exe is launched on Windows (located at C:\Users\<my-user-name>\AppData\Local\Programs\alephium-wallet\Alephium.exe), the mainWindow variable is set to null.

Need to keep debugging...

from desktop-wallet.

I managed to reproduce the issue. I still haven't found a solution. Some notes during my debugging:

• We create new windows only when 2 events get triggered: ready and activate.
• Even when commenting out the callback of the activate event completely, when clicking the installed Windows Alephium app it still opens a second window. The only place where createWindow is now called is in the ready event callback. Updating the callback to the following snippet does not solve the problem (second window opens again):

  app.on('ready', () => {
    if (mainWindow === null) createWindow()
  })

• I tried this, also no success:

  app.on('ready', () => {
    if (BrowserWindow.getAllWindows().length === 0) createWindow()
  })

• I tried updating the snippet to the following, again, without success:

  app.whenReady().then(() => {
    if (mainWindow === null) createWindow()
  })

• It would seem that every time the installed exe is launched on Windows (located at C:\Users\<my-user-name>\AppData\Local\Programs\alephium-wallet\Alephium.exe), the mainWindow variable is set to null.

Need to keep debugging...

Is this the same for Macos ?

from desktop-wallet.

Is this the same for Macos ?

No. Everything works fine there.

from desktop-wallet.

It turns out that this is not a bug. This is the expected behavior on Windows. Here is an example with another popular electron app (Visual Studio Code). As you can see in the demo, double-clicking the executable opens a new window, exactly as it happens with our wallet.

from desktop-wallet.

However, if an account has already been created, the second window should display the Login page, not the new wallet creation/import page.

from desktop-wallet.

For the record, here's a demo of the problem:

from desktop-wallet.