Wallet header color does not respect Windows dark theme setting about desktop-wallet HOT 7 CLOSED

I'll haul my Windows machine out from the basement to test since I need it anyway to access some drives...

from desktop-wallet.

Confirmed working by @sven-hash! ✨ Even says it works without restarting the application.

from desktop-wallet.

I think electron/electron#23479 gives a better understanding of the issue and better solutions than the two you've linked. I agree, it looks non-trivial to deal with as a web developer.

As someone said concisely:

Electron has implemented a fix, however it uses nonpublic APIs and is therefore gated behind a build flag (electron/electron#23479 (comment)).

We can opt to use this build flag or ignore the issue. IMO as long as we "keep on top" of using the nonpublic API, it's ok, since this is just for non-consequential eye-candy.

Code-wise the solution appears to be simple:

const { nativeTheme } = require('electron')
nativeTheme.themeSource = 'system'

But I'm not sure if this requires us to build a particular version of electron.

from desktop-wallet.

If this is the fix, and we can verify that it works (in need of a windows machine), then I say let's just fix it.

from desktop-wallet.

https://github.com/electron/electron/releases/tag/v20.0.0 Added immersive dark mode, simply updating should correct the problem

from desktop-wallet.

I think this is more complicated than it looks.

Have a look here: https://stackoverflow.com/questions/46222035/set-color-of-windows-titlebar-electron-js

and here: https://www.npmjs.com/package/custom-electron-titlebar

from desktop-wallet.

Well my Window's machine appears to be dead. It won't power on at all... Going to ask some users in the Discord.

from desktop-wallet.