Comments (2)
@rpbeltran First of all thanks so much for finding that bug. It seems like there's a few other bugs surrounding the panel appending logic and how it caches the collection of items. I can either work on a fix or if you want to as well that would be totally awesome. I'd also take a look at the rounding logic (i.e. Math.floor) as it can sometimes be finicky if you want to open a PR. Second it's awesome that you're using the plugin, I'd love to see the final product when you're finished!
from patch-panel.
Thanks for the help. I submitted a PR with a fix. It now works just fine for me, but I had a couple quick questions that I was hoping you could answer.
- You added an event in bindEvent to hide all the panels when you resize the window so that the responsive design can take effect. Would it be better if it reopened again afterwords in the corrected size?
- In the line
var $hiddenPanel = $(plugin.panelSelector + "[data-patch-panel=" + $el.attr("data-patch-panel") + "]").add();
am I wrong in thinking the .add() is superfluous? - I noticed a minor error in the demo page, the given jQuery initialization code had a small error, it is missing a comma after
panelSelector: '.grid-panel'
from patch-panel.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from patch-panel.