Comments (6)
A pull request would be great. In particular, I'll be looking for tests of the existing working array functionality, to make sure those don't break. Confirming that they already exist sufficiently is fine. I'm certain that I do have an ArrayField in my production work project that is working, so as long as I don't break that, I'm happy to clean up other issues.
It seems like you've got a reasonable grasp on this issue. I don't yet. But a pull request would be welcome, and I will review it. Thank you for reporting the issue.
from aldjemy.
While preparing a branch for this PR I was running tests with tox and found few more issues.
- It seems that latest python3 versions that is used by tox by default having sqlite3 versions incompatible with specified in tox.ini Django versions 2.0.9 and 2.1.3. I had a similar error as described here:
https://stackoverflow.com/questions/53637182/django-no-such-table-main-auth-user-old
Updating Django version to 2.0.10 and 2.1.5 fixed the issue.
- In postgres test project there is a model named JsonModel. But no migration to add it to DB provided. Every test run fails for me with attempt to fetch JsonModel table right after creation of test database.
Adding migration for JsonModel fixed this as well.
Should I create separate PRs for this two?
from aldjemy.
- I'm not sure how you hit that issue, unless you just had an old .tox directory somehow. The tox.ini config should be using the latest patch releases of Django.
- If the change is related to this change, or uncovered by your new work, go ahead and make it the same pull request, and explain what happened and why your change uncovered it. If it already exists in the master branch, then I'd make it a separate issue, so that it's easier for me to review and merge it separately.
from aldjemy.
- I'm not sure how you hit that issue, unless you just had an old .tox directory somehow. The tox.ini config should be using the latest patch releases of Django.
Gosh, my bad. I've missed that update. Sorry about that.
- If the change is related to this change, or uncovered by your new work, go ahead and make it the same pull request, and explain what happened and why your change uncovered it. If it already exists in the master branch, then I'd make it a separate issue, so that it's easier for me to review and merge it separately.
it's in the master branch now. Looks like a separate case to me. I'll provide more info later.
from aldjemy.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from aldjemy.
I believe this is now fixed in #101 .
from aldjemy.
Related Issues (20)
- Settings import conflict in aldjemy.table HOT 2
- Add DateRangeField to default types
- Transaction is rollback unconditionally on connection `connect` event HOT 3
- option to pass future=True to engine and session HOT 11
- Migration guide for v2 deprecations HOT 6
- Inconsistency with json serialization HOT 22
- sqlalchemy v2 deprecation (orm.mapper)
- ManyToMany fields with through parameter raise SA warning
- ORM layer produce some warnings with SQLA 1.4
- Should we switch to pytest (and pytest-django) ? HOT 2
- SAWarning on EmailAddress HOT 18
- Error with M2M fields that have through attribtute: TypeError: sequence item 3: expected str instance, NoneType found HOT 1
- M2M query HOT 2
- Use db_column in ForeignKey field HOT 6
- Replace current Django connection by the new, asynchronous, directly created from the SQLAlchemy HOT 8
- Switch to regular build tools HOT 1
- Is there a way to exclude a Django model or field from Aldjemy model creation? HOT 4
- Outdated comment in core.py? HOT 1
- SQLAlchemy 2 compatibility HOT 8
- Support Psycopg 3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aldjemy.