Giter Club home page Giter Club logo

Comments (6)

ryanhiebert avatar ryanhiebert commented on June 23, 2024

A pull request would be great. In particular, I'll be looking for tests of the existing working array functionality, to make sure those don't break. Confirming that they already exist sufficiently is fine. I'm certain that I do have an ArrayField in my production work project that is working, so as long as I don't break that, I'm happy to clean up other issues.

It seems like you've got a reasonable grasp on this issue. I don't yet. But a pull request would be welcome, and I will review it. Thank you for reporting the issue.

from aldjemy.

SnakeOilSalesman avatar SnakeOilSalesman commented on June 23, 2024

While preparing a branch for this PR I was running tests with tox and found few more issues.

  1. It seems that latest python3 versions that is used by tox by default having sqlite3 versions incompatible with specified in tox.ini Django versions 2.0.9 and 2.1.3. I had a similar error as described here:
    https://stackoverflow.com/questions/53637182/django-no-such-table-main-auth-user-old

Updating Django version to 2.0.10 and 2.1.5 fixed the issue.

  1. In postgres test project there is a model named JsonModel. But no migration to add it to DB provided. Every test run fails for me with attempt to fetch JsonModel table right after creation of test database.

Adding migration for JsonModel fixed this as well.

Should I create separate PRs for this two?

from aldjemy.

ryanhiebert avatar ryanhiebert commented on June 23, 2024
  1. I'm not sure how you hit that issue, unless you just had an old .tox directory somehow. The tox.ini config should be using the latest patch releases of Django.
  2. If the change is related to this change, or uncovered by your new work, go ahead and make it the same pull request, and explain what happened and why your change uncovered it. If it already exists in the master branch, then I'd make it a separate issue, so that it's easier for me to review and merge it separately.

from aldjemy.

SnakeOilSalesman avatar SnakeOilSalesman commented on June 23, 2024
  1. I'm not sure how you hit that issue, unless you just had an old .tox directory somehow. The tox.ini config should be using the latest patch releases of Django.

Gosh, my bad. I've missed that update. Sorry about that.

  1. If the change is related to this change, or uncovered by your new work, go ahead and make it the same pull request, and explain what happened and why your change uncovered it. If it already exists in the master branch, then I'd make it a separate issue, so that it's easier for me to review and merge it separately.

it's in the master branch now. Looks like a separate case to me. I'll provide more info later.

from aldjemy.

stale avatar stale commented on June 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from aldjemy.

ryanhiebert avatar ryanhiebert commented on June 23, 2024

I believe this is now fixed in #101 .

from aldjemy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.