Cannot get rid of timer! about easytimer.js HOT 8 CLOSED

Hi!

thank you for opening the issue. I'll try to fix this as soon as possible.

Best regards.

from easytimer.js.

Thanks! I wouldn't have noticed it, except the tables sometimes get the same records added back after they were removed... and the items I was using for the ids of the spans were the same as the previous times the rows were in the table. This ended up causing really weird behavior, which I eventually tracked down to the fact that the span was being updated by multiple timers!

I've worked around that by just adding Date.now() to the id... but, I'm sure the timers take up at least some memory, so, being able to get rid of them completely would still be nice.

Also, the documentation doesn't clarify if you can call removeEventListener without the 2nd parameter, and have all listeners removed, or if the original callback is required. If not supported, it definitely would be nice to be able to remove all by not specifying a 2nd parameter.

from easytimer.js.

Hi again!

I can't reproduce the bug. I made a unit test of this function and it seems to work ok. If you can show me an example of the bug It will be easier to fix it. You can see the test here.

The removeEventListener function is a wrapper of the function with the same name in the EventTarget object. You can read the documentation here.

I could add the behavior of removing all listeners but is not the goal of this function, and I don't want to add more complexity to the library.

Thank you again!

from easytimer.js.

https://jsfiddle.net/8uuku5gs/5/

from easytimer.js.

Hi!

There is a typo in your example. You wrote t1.removeEventLister("secondsUpdated",cb); instead of t1.removeEventListener("secondsUpdated",cb);. If you change that it works as expected.

Best regards.

from easytimer.js.

Is there someplace I can send you a link to a secret gist? It has some proprietary code, so I don't want to make it publicly available.

from easytimer.js.

Of course, you can send me an email: [email protected]

from easytimer.js.

I can't reproduce the bug. I close the issue. If someone has an example, please reopen and I'll check it out.

from easytimer.js.