Block-autoplay experiment is not removed after its expiration date about autoplay-shield-study HOT 5 CLOSED

I've committed 04f58a1 and a49276b to ensure we would clean up all stuff and uninstall itself when the study ends.

However, the uninstalling process couldn't be tested on about:addon, because the uninstalling process of shield-study addons is different with the process of normal addons. For normal add-ons, we use addon manager to uninstall them which won’t give addons any time to do clean-up when uninstalling them.

That is the reason why uninstallation would fail on this bug, because the extension had been destroyed before we called cleanup(), and then it results in errors in cleanup() so that we can't uninstall the addon correctly.

However, in a real situation, we would uninstall shield-study addons by Normandy, which would give shield-study addons enough time to do clearup() before uninstallation.

from autoplay-shield-study.

In addition, I've asked the shield-study team, they told me that now they didn't have any way to test the uninstalling process of shield study...

from autoplay-shield-study.

Our concern is that there is the possibility of Normandy failing on the study expiry step, since we don't have any control over this. If possible, we think it would be better for everyone to implement an expiry date based on the installation time as a fail safe mechanism.
These dual checks were already implemented on most of the studies tested by the team until now and worked perfectly.

However, if you guys don't see this as a problem / risk, please let us know so we won't invest any testing time on this part.

from autoplay-shield-study.

@Softvision-RemusDranca Ah, I think I found where the problem is, it's fixed by 74228da.

Thank you!

from autoplay-shield-study.

I have verified this issue using the latest Block Autoplay (2.0.0) version and the issue is no longer reproducible. Tested on Windows 10 x64, Mac 10.13 and Ubuntu 18.04 x64.
Thank you for fixing this!

from autoplay-shield-study.