webpack-loader with object rest spread plugin fails parsing about sucrase HOT 7 CLOSED

Thanks, glad to hear! I'll actually reopen to track the task of updating the docs and maybe adding a runtime check.

from sucrase.

@iki Take a look at webpack/webpack#5548 (comment) , that may have some pointers. I think there are unfortunately some node_modules issues where it's possible to be stuck on an old acorn even though webpack 4 should depend on a recent enough version that supports the syntax. The syntax works for me in webpack 4 with a fresh install, so maybe try reinstalling node_modules from scratch or regenerating your lockfile.

from sucrase.

Thanks for reporting. Since you're on webpack 4, I think object rest/spread should actually work without webpack-object-rest-spread-plugin. I wrote that plugin before webpack 4 came out, and it's still needed on 3 or earlier. Could you try removing that plugin and see if it works and that you can still have object rest/spread in your code?

I'll update the docs to say that webpack-object-rest-spread-plugin is not needed in webpack 4. It looks like webpack 4 changed enough to break the plugin, so I'll also see if I can make it print a warning and do nothing if it detects that you're on webpack 4.

from sucrase.

Oh yeah, it works without. I just blindly assumed it was necessary.
Thank you, and keep up the nice project :)

from sucrase.

@alangpierce Actually, I get the above error with webpack4, typescript and webpack-object-rest-spread-plugin. However, if I remove the spread plugin, I get error on the first spread operator:

ERROR in ./src/containers/App.tsx
Module build failed: SyntaxError: ./src/containers/App.tsx: Unexpected token (17:37)

> 17 | const SwitchWithProps = ({ children, ...restProps }) => (

from sucrase.

@alangpierce thanks! updating acorn resolved that: webpack/webpack#5548 (comment)

from sucrase.

Cool, glad to hear.

from sucrase.