Default closure based ImageFilter struct about alamofireimage HOT 5 CLOSED

We can even think of a custom operator to create composite image filters:

let filter = SizeToFillFilter(size: size) => CircleFilter() => MyCustomFilter()

which is clearer and shorted than:

let filter = CompositeImageFilter(filters: SizeToFillFilter(size: size), CircleFilter(), MyCustomFilter())

from alamofireimage.

I think something like DynamicImageFilter or CustomImageFilter that takes an identifier and trailing filter closure in the initializer could definitely be useful. If you want to take a stab at this along with some tests, that would be awesome!

As for a similar type of CompositeImageFilter, I think it would be good to have one that has an initializer that takes an array of filters. I think a variadic initializer is fine as well. How about both? Also, how about a name like DynamicCompositeImageFilter?

Now as for adding operator overloads, I'm hesitant. If you'd like to put that together in the PR, then I'll gladly take a look. No promises though on actually merging that. Just thinking through it off the top of my head it would have to merge two ImageFilter comforming objects into a CompositeImageFilter, then append additional filters into the composite. It would certainly be more clear and only slightly more verbose to use a variadic initializer on the DynamicCompositeImageFilter. My two cents...

from alamofireimage.

@cnoon ok, let's first start with DynamicImageFilter and DynamicCompositeImageFilter. I think we'll have to use them before deciding wether custom operators are useful for creating composite filters.
I'll try to PR in the next few days.

from alamofireimage.

Okay sounds great. Just let me know if you need anything from me!

from alamofireimage.

Completed in #14.

from alamofireimage.