Giter Club home page Giter Club logo

Comments (3)

kchibisov avatar kchibisov commented on August 10, 2024 1

No, the problem is not metrics but setting sizes for the font, and we do that differently for colored glyphs and normal glyphs, however we make decision about colored glyphs on a font level, and not per glyph basis.

It basically breaks somewhere here

crossfont/src/ft/mod.rs

Line 305 in 1100c6e

freetype_sys::FT_Select_Size(ft_face.raw_mut(), 0);

in pair with not calling

crossfont/src/ft/mod.rs

Line 436 in 1100c6e

face.ft_face.set_char_size(to_freetype_26_6(pixelsize), 0, 0, 0)?;
. I haven't looked much into it all, since not in the mood to try random freetype things to make it work...

from crossfont.

chrisduerr avatar chrisduerr commented on August 10, 2024

Could you go into a bit more detail here? Are we talking about the response from the metrics function being incorrect? That should just call out to full_metrics, right? Which doesn't have special handling for colored glyphs as far as I can see.

The only difference we have in metrics for colored glyphs would be in get_rendered_glyph, which affects only the glyph itself. So chances are you mean that here if the face itself is colored, this path is taken for every single glyph even if the individual glyph is not colored? Thus performing bitmap scaling.

from crossfont.

chrisduerr avatar chrisduerr commented on August 10, 2024

This also affects macOS: alacritty/alacritty#4415.

from crossfont.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.