libsnark fails for circuits with checkNonZero depending on execution order about jsnark HOT 2 CLOSED

Please confirm if it works completely fine under the same input before applying the suggested fix above.

I made the change to line 618 as you suggested, and everything works as it's supposed to now 🎉

I think I also found the reason why the first case (// Works) worked on my machine - I was actually using a fork of libsnark that seems to contain a workaround for the first bug; and I completely missed that commit when I created this issue 😅

Thank you so much for your help!

from jsnark.

Hi,

Thanks for catching this problem and for helping with the minimal examples!

I traced the problem and found that line 618 in CircuitReader.cpp needs to be zeroPwires.push_back(make_shared<LinearCombination>(*l));  instead of zeroPwires.push_back(l);.
I will push the fix later with other unrelated changes after verifying that it works, but so far, the problem seems to be in this line only. The problem appears in the patterns that you described, and when it happens, it leads to an observable error.

By the way, you mentioned that the code you provided works if the other line that sets resultPlusOne is used. I checked both cases, and both did not work before the fix. In the first case, the error is as you reported. In the second case, there is another exception. Both problems are fixed by changing the line that I mentioned above, but I am curious about the different behavior in the second case. Please confirm if it works completely fine under the same input before applying the suggested fix above.

from jsnark.