Comments (8)
Hi; the library will compile just fine if you provide the configuration options (which codecs to include) via command line or a hardcoded config.h
. So you just need to create a build definition or use the cmake build scripts I created, see #7 and/or BurningEnlightenment/base64-cmake
EDIT: my build scripts haven't been updated to include the last two commits due to lack of time; if you invest time into updating my build scripts, I would happily accept a PR π
from base64.
Hey, thanks for the compliment. Allow me to explain why I've been reluctant to merge the cmake fork. The situation is a bit nuanced, as I hope will become clear.
On the surface, the issue seems straightforward. Support for cmake is probably the most requested feature for this library. The code in question has already been written and is being maintained externally. The person who wrote it (@BurningEnlightenment) did a good job and spent quite some effort on it, even rewriting it once. The code could be merged right now without much of a problem. Then why not merge it?
The thing is that I don't know cmake. Adding cmake support means that it will be there permanently as a core feature. It would forever place on me the burden of maintaining a piece of code in the heart of the project that I do not understand and cannot reason much about. I fear that this could become a liability to the project if I'm not familiar enough with cmake to update (or modernize) it as time changes. It would risk turning into a poorly understood layer of arcane magic spells. It would feel like part of the project slipped out beyond my control.
The way out of this is clear: I should just get on with it and learn cmake. Which is what I said I'd do a long time ago πΏ
In the meantime I think it wouldn't be too unreasonable to just use the cmake fork if it works for you. This library is fairly stable, it's not something I spend much time or thought on anymore, so you don't have to be too afraid of diverging branches. And if the branches do diverge, it's probably because the official project got cmake support πΈ
from base64.
@BurningEnlightenment Thanks! I'm not familiar with scripting camke yet. But I'll try to rewrite it when i have time. (By the way, what's the meaning of this PR? I'm a freshman in English.)
from base64.
from base64.
@BurningEnlightenment Thanks again!
from base64.
@aklomp @tomcatter may consider closing this issue?
from base64.
Hi, I just found your library and want to say "two thumbs up for the great work!".
But can I also kindly ask if the cmake-based build instructions could be included in the official release? It seems the cmake-fork is current up-to-date, but since base64 can be used in security-related applications I'd very much like to be on the official repo and not on a fork. It's really just a humble request, please do not feel pushed into something. But the cmake build is really nice due to cross platform support and the install target.
from base64.
CMake support was recently merged into master
(see #7), so this library now supports compilation on Windows.
from base64.
Related Issues (20)
- bin/base64: modernize the demo program
- Add a macro to calculate encoded size from raw size and vice versa
- Investigate `gf2p8affineqb` for the shuffle step
- enc: asm: add memory and flags as clobbers
- Integrate with google/oss-fuzz for continuous fuzz testing
- Create release 0.5.1
- Codec detection doesnβt work in test_base64 on musl libc HOT 3
- v0.5.1 breaks `base64 -d` on Alpine Linux (musl libc) HOT 15
- Build of 0.5.1 broken with MinGW HOT 15
- I made a online base64 decoder tool. We can use it HOT 1
- Simplify codepath selection HOT 4
- build failure using mingw32: `error: 'asm' operand has impossible constraints` HOT 4
- CMakeLists: update version to 0.5.2
- bin/base64: add command line options for decoding
- Add `BASE64_FORCE_INLINE` macro to always inline inner loop functions
- Decoding error on Windows (CRLF?) HOT 18
- Codepage error on Windows HOT 2
- Build fails on macOS: `make: objcopy: No such file or directory` HOT 2
- Add installation guide for lib HOT 2
- error: implicit declaration of function 'bit' is invalid in C99 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from base64.