Giter Club home page Giter Club logo

Comments (10)

ignasi35 avatar ignasi35 commented on June 18, 2024

or have a utility for setting up dummy test certificates on both sides.

Akka could ship fake certs on the testkit, or there could be a tool to crete a CA and a server cert on the fly.

For Lagom we spiked the second alternative and built a FakeKeyStoreGenerator.scala based on Play's FakeKeyStore.

from akka-grpc.

raboof avatar raboof commented on June 18, 2024

I think @richdougherty has been working on that, seeing if it is reasonable to use ssl-config here or we can make it convenient some other way.

from akka-grpc.

ktoso avatar ktoso commented on June 18, 2024

Right, I think our approach here should be "whichever style play already does it for dev" :)
If ssl config helps then good, but if not then don't force it in I think. It may be nice to use just to declare from where to load certs, but not expose it in any APIs unless needed perhaps for example.

from akka-grpc.

patriknw avatar patriknw commented on June 18, 2024

Remember to remove the certs from Quickstarts also, e.g. akka/akka-grpc-quickstart-scala.g8#1 (comment)

from akka-grpc.

ktoso avatar ktoso commented on June 18, 2024

The comment to do what play does still stands, but they what play does does not work very well now: playframework/playframework#8562 would need to be implemented and based on.

There's some weird cycles about generating and needing the cert

from akka-grpc.

ktoso avatar ktoso commented on June 18, 2024

For plain Akka to generate the certs we'd need to "steal" code that play has for these things I suppose:

from here

Rich Dougherty:
https://github.com/playframework/playframework/blob/master/framework/src/play-server/src/main/scala/play/core/server/ssl/FakeKeyStore.scala#L53-L82

Rich Dougherty:
https://github.com/playframework/playframework/blob/master/framework/src/play-server/src/main/scala/play/core/server/ssl/DefaultSSLEngineProvider.scala#L62

from akka-grpc.

patriknw avatar patriknw commented on June 18, 2024

We discussed this some more and concluded that the plain vanilla samples can be without TLS.
We can run without SSL, but then we cannot serve 'regular' HTTP requests on that port anymore. We also have to add documentation of how to enable TLS (if that doesn't exist).

from akka-grpc.

ignasi35 avatar ignasi35 commented on June 18, 2024

Now that TLS is not required for akka-gRPC I think we'd better close this issue.

I would ship the .g8 templates with some sample certificates/keys and maybe some very vague instructions on how to recreate them (with a disclaimer wrt key size, state of art, etc etc) but detailed instructions on relevant details (e.g. subject, authority, ...).

Lagom provides in both DevMode and TestKit tools to create fake certificates on the fly. In the case of testkit, there's also an SSLContext baked for the client in tests so it trusts the server in the testkit. I don't think such mechanisms should be part of akka-grpc.

from akka-grpc.

ignasi35 avatar ignasi35 commented on June 18, 2024

raised akka/akka-grpc-quickstart-java.g8#39

from akka-grpc.

ignasi35 avatar ignasi35 commented on June 18, 2024

(sorry, pressed the wrong buttons)

from akka-grpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.