Giter Club home page Giter Club logo

Comments (3)

emjoseph avatar emjoseph commented on June 6, 2024 1

Hey,
From the way the codebase is set up, to fix this issue do something like this to fix this issue:

[self.player setMeteringEnabled:NO];
[self.player replaceCurrentItemWithPlayerItem:item];
[self.player setMeteringEnabled:YES];

I.E make sure to turn metering off before changing the player item and then turn back on after replacement.

This behavior happens because of the -(void)setMeteringEnabled:(BOOL)iMeterinngEnabled method in ACBAudioProcessHelper.m file.

- (void)setMeteringEnabled:(BOOL)iMeteringEnabled {
    
    if (!self.isMeteringEnabled && iMeteringEnabled) {
       c
    } else if (self.isMeteringEnabled && !iMeteringEnabled) {
        self.player.currentItem.audioMix = nil;
    }

    _meteringEnabled = iMeteringEnabled;
}

[self setupMetering] is never called for the new item unless you manually turn off metering and then turn it on again.

from acbavplayerextension.

akhilcb avatar akhilcb commented on June 6, 2024

Apologies for the delay in replying. This should work again if you set metering enabled to YES again. I am not sure why it was happening since I was not able to reproduce this when I set it to YES again. If you found any solution, please submit a PR.

from acbavplayerextension.

akhilcb avatar akhilcb commented on June 6, 2024

This should be fixed in v2.1. I have added a new replaceCurrentItemAndUpdateMeteringForPlayerItem which should do the above automatically. Please update here if it doesn't work for you.

from acbavplayerextension.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.