Comments (11)
ajrgodfrey
commented on July 17, 2024
Suspect an example is needed for this to provide a test of your solutions.
From: Sophie Banks <[email protected]>
Sent: Thursday, 21 January 2021 2:08 PM
To: ajrgodfrey/BrailleR <[email protected]>
Cc: Subscribed <[email protected]>
Subject: [ajrgodfrey/BrailleR] VI() descriptions for geom_histogram() give really inaccurate numbers of bars (#35)
VI() for geom_histogram has really weird ideas about numbers of bars. I expect that when sorting by categories it is including any missing category from each bar as a completely missing bar.
eg.
geom_histogram(aes(x, fill=catsOneToSeven), bins=5)
VI() will say that there are 35 vertical bars if there are 7 cats, regardless of whether the colours are included in the bar, and the fact that the default has them stacked and will not leave gaps for missing fill cats.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#35>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADCZKGTILMNQKNLM76GFVDDS255ALANCNFSM4WL2QZ2A>.
from brailler.
boringNectarine0
commented on July 17, 2024
l<-ggplot(iris) +
geom_histogram(aes(y=Sepal.Width, fill=Species),bins = 5)
l
VI(l)
In the VI() description it says "The chart is a bar chart containing 15 vertical bars."
from brailler.
ajrgodfrey
commented on July 17, 2024
5 bins and 3 species?? Would be wrong of course but is an explanation.
From: Sophie Banks <[email protected]>
Sent: Thursday, 21 January 2021 7:44 PM
To: ajrgodfrey/BrailleR <[email protected]>
Cc: Godfrey, Jonathan <[email protected]>; Comment <[email protected]>
Subject: Re: [ajrgodfrey/BrailleR] VI() descriptions for geom_histogram() give really inaccurate numbers of bars (#35)
l<-ggplot(iris) +
geom_histogram(aes(y=Sepal.Width, fill=Species),bins = 5)
l
VI(l)
In the VI() description it says "The chart is a bar chart containing 15 vertical bars."
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADCZKGRDL5EDSKWYVANZOBDS27ELHANCNFSM4WL2QZ2A>.
from brailler.
boringNectarine0
commented on July 17, 2024
If there was a bar chart with space for 10 bars, but 2 gaps (or 2 bars of 0 height) would we ideally have that said to be 8 bars?
from brailler.
ajrgodfrey
commented on July 17, 2024
No.
There is a difference between no observation and a zero observation.
As an example, I’ve been helping an ecology student who has been looking for weta. If she goes into the bush and finds nothing then that is different to her not going into the bush at all. She should have a bar for each bush trip, but of zero height on the bad days.
From: Sophie Banks <[email protected]>
Sent: Sunday, 14 February 2021 4:27 PM
To: ajrgodfrey/BrailleR <[email protected]>
Cc: Godfrey, Jonathan <[email protected]>; Comment <[email protected]>
Subject: Re: [ajrgodfrey/BrailleR] VI() descriptions for geom_histogram() give really inaccurate numbers of bars (#35)
If there was a bar chart with space for 10 bars, but 2 gaps (or 2 bars of 0 height) would we ideally have that said to be 8 bars?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADCZKGUVLTYG5PJNRKRYTLLS647HTANCNFSM4WL2QZ2A>.
from brailler.
boringNectarine0
commented on July 17, 2024
Is bar height of 0 something worth having in VI() descriptions? By the way, would you have time to reply to my emails? Thanks.
from brailler.
ajrgodfrey
commented on July 17, 2024
Yes, zero height bars are important as that is a gap in the data (histogram) or if categorical data then shows a zero count which might be an anomaly.
On a bus with adequate wifi at the moment. ~30 minutes to spare
J
From: Sophie Banks <[email protected]>
Sent: Sunday, 14 February 2021 5:17 PM
To: ajrgodfrey/BrailleR <[email protected]>
Cc: Godfrey, Jonathan <[email protected]>; Comment <[email protected]>
Subject: Re: [ajrgodfrey/BrailleR] VI() descriptions for geom_histogram() give really inaccurate numbers of bars (#35)
Is bar height of 0 something worth having in VI() descriptions? By the way, would you have time to reply to my emails? Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADCZKGX7MCXHZ7GLER2YN6TS65FCVANCNFSM4WL2QZ2A>.
from brailler.
boringNectarine0
commented on July 17, 2024
Another example here is saying that graph is 8 bars
data <- data.frame(
quarter=c("Q1", "Q1", "Q2", "Q2", "Q3", "Q3", "Q4", "Q4"),
product=c("A", "B", "A", "B", "A", "B", "A", "B"),
profit=c(10, 11, 12, 11, 13, 15, 16, 18)
)
VI(ggplot(data, aes(x = quarter, y = profit)) +
geom_bar(stat = "identity")
)
because there is a small number of bars the points are described so it does make some sense but as there is no sorting by product A/B this is rather odd.
from brailler.
ajrgodfrey
commented on July 17, 2024
I assume you mean the description does not recognise the distinction for product?
The question is what is on the actual graph? Does the description lead you to expect what you see?
N.B. if this example is to feature as a test somewhere, it would be better to use data.frame(expand.grid(Quarter = c(…), Product = c(“A”, “B”)), Count=c(…))
With the first … being the set of quarter names (four only).
You shouldn’t need to switch the two variables in the expand.grid() but choose the one that works for you.
From: Sophie Banks <[email protected]>
Sent: Sunday, 14 February 2021 5:36 PM
To: ajrgodfrey/BrailleR <[email protected]>
Cc: Godfrey, Jonathan <[email protected]>; Comment <[email protected]>
Subject: Re: [ajrgodfrey/BrailleR] VI() descriptions for geom_histogram() give really inaccurate numbers of bars (#35)
Another example here is saying that graph is 8 bars
data <- data.frame(
quarter=c("Q1", "Q1", "Q2", "Q2", "Q3", "Q3", "Q4", "Q4"),
product=c("A", "B", "A", "B", "A", "B", "A", "B"),
profit=c(10, 11, 12, 11, 13, 15, 16, 18)
)
VI(ggplot(data, aes(x = quarter, y = profit)) +
geom_bar(stat = "identity")
)
because there is a small number of bars the points are described so it does make some sense but as there is no sorting by product A/B this is rather odd.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADCZKGRAUM5Y5TOODDZBMPDS65HMFANCNFSM4WL2QZ2A>.
from brailler.
boringNectarine0
commented on July 17, 2024
The description makes it seem like there is some sort of deviation between
product shown on the graph when there is not. There are only four plain
bars depicted.
…On Sun, 14 Feb 2021 at 17:49, Jonathan Godfrey ***@***.***> wrote:
I assume you mean the description does not recognise the distinction for
product?
The question is what is on the actual graph? Does the description lead you
to expect what you see?
N.B. if this example is to feature as a test somewhere, it would be better
to use data.frame(expand.grid(Quarter = c(…), Product = c(“A”, “B”)),
Count=c(…))
With the first … being the set of quarter names (four only).
You shouldn’t need to switch the two variables in the expand.grid() but
choose the one that works for you.
From: Sophie Banks ***@***.***>
Sent: Sunday, 14 February 2021 5:36 PM
To: ajrgodfrey/BrailleR ***@***.***>
Cc: Godfrey, Jonathan ***@***.***>; Comment <
***@***.***>
Subject: Re: [ajrgodfrey/BrailleR] VI() descriptions for geom_histogram()
give really inaccurate numbers of bars (#35)
Another example here is saying that graph is 8 bars
data <- data.frame(
quarter=c("Q1", "Q1", "Q2", "Q2", "Q3", "Q3", "Q4", "Q4"),
product=c("A", "B", "A", "B", "A", "B", "A", "B"),
profit=c(10, 11, 12, 11, 13, 15, 16, 18)
)
VI(ggplot(data, aes(x = quarter, y = profit)) +
geom_bar(stat = "identity")
)
because there is a small number of bars the points are described so it
does make some sense but as there is no sorting by product A/B this is
rather odd.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<
#35 (comment)>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/ADCZKGRAUM5Y5TOODDZBMPDS65HMFANCNFSM4WL2QZ2A>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOWHJFIJBO6J4AT4WKLZYFLS65I33ANCNFSM4WL2QZ2A>
.
from brailler.
ajrgodfrey
commented on July 17, 2024
That’s a big one then.
Definitely should say 4 bars in the description if you see only four in the graph!
From: Sophie Banks <[email protected]>
Sent: Sunday, 14 February 2021 5:54 PM
To: ajrgodfrey/BrailleR <[email protected]>
Cc: Godfrey, Jonathan <[email protected]>; Comment <[email protected]>
Subject: Re: [ajrgodfrey/BrailleR] VI() descriptions for geom_histogram() give really inaccurate numbers of bars (#35)
The description makes it seem like there is some sort of deviation between
product shown on the graph when there is not. There are only four plain
bars depicted.
On Sun, 14 Feb 2021 at 17:49, Jonathan Godfrey ***@***.******@***.***>> wrote:
I assume you mean the description does not recognise the distinction for
product?
The question is what is on the actual graph? Does the description lead you
to expect what you see?
N.B. if this example is to feature as a test somewhere, it would be better
to use data.frame(expand.grid(Quarter = c(…), Product = c(“A”, “B”)),
Count=c(…))
With the first … being the set of quarter names (four only).
You shouldn’t need to switch the two variables in the expand.grid() but
choose the one that works for you.
From: Sophie Banks ***@***.******@***.***>>
Sent: Sunday, 14 February 2021 5:36 PM
To: ajrgodfrey/BrailleR ***@***.******@***.***>>
Cc: Godfrey, Jonathan ***@***.******@***.***>>; Comment <
***@***.******@***.***>>
Subject: Re: [ajrgodfrey/BrailleR] VI() descriptions for geom_histogram()
give really inaccurate numbers of bars (#35)
Another example here is saying that graph is 8 bars
data <- data.frame(
quarter=c("Q1", "Q1", "Q2", "Q2", "Q3", "Q3", "Q4", "Q4"),
product=c("A", "B", "A", "B", "A", "B", "A", "B"),
profit=c(10, 11, 12, 11, 13, 15, 16, 18)
)
VI(ggplot(data, aes(x = quarter, y = profit)) +
geom_bar(stat = "identity")
)
because there is a small number of bars the points are described so it
does make some sense but as there is no sorting by product A/B this is
rather odd.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<
#35 (comment)>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/ADCZKGRAUM5Y5TOODDZBMPDS65HMFANCNFSM4WL2QZ2A>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOWHJFIJBO6J4AT4WKLZYFLS65I33ANCNFSM4WL2QZ2A>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADCZKGU3S5H7V7FKW64DL53S65JNVANCNFSM4WL2QZ2A>.
from brailler.
Related Issues (20)
- No indication of what type of graph is shown if it is one that VI() cannot process HOT 4
- VI() always says that the legend is hidden when using scale_fill_continuous() HOT 1
- Bars in geom_histogram() are always said to be vertical, which they are not HOT 2
- Positioning of data groups not mentioned HOT 1
- Weird syntax for when coloured fill is used to show groupings HOT 2
- Liblouis Text Translation HOT 1
- pdf2html fails HOT 1
- Change ggplot shape descriptions
- geom_boxplot not displaying correct description from VI()
- TimeSeriesPlot does not work with ggplot
- Splitting Describe and VI help pages and merging VI help pages HOT 1
- XML package casuing windows build to crash
- pkgdown failing to build HOT 3
- ggplot VI cant handle varied coordinate systems HOT 1
- Add VI and describe information to SVG webpage? HOT 1
- Move the whiskers templates from html to md HOT 1
- Summarise and fleshout SVGs and XMLs of "bar" and "line" type ggplots geoms HOT 1
- Add SVG and XML support for multiple layers HOT 1
- GeomPoint points not highlighted correctly in MakeAccessibleSVG
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brailler.