Giter Club home page Giter Club logo

Comments (2)

mlablah avatar mlablah commented on May 18, 2024

I think there are two issues at play.

  1. How should unrecognized addons be displayed?
  2. Should we only try and match addons using their ID from the toc file, if one is present?

Regarding #1 I think your solution of adding "-" to the second column is fine. Though I think the columns could use some titles. Eg. "Your version" and "Latest version" or something similar.

Regarding #2 I noticed that Angry Notes is hosted on Curseforge (https://www.curseforge.com/wow/addons/angry-notes). Maybe as a fall back, if no ID's are present, do a textual search based on Title (without web colors).

Do the APIs (curse/wowi/tukui) support that?

from ajour.

casperstorm avatar casperstorm commented on May 18, 2024

Regarding #1 I think your solution of adding "-" to the second column is fine. Though I think the columns could use some titles. Eg. "Your version" and "Latest version" or something similar.

I'll create a separate issue on this, and make that happen. #20

Regarding #2 I noticed that Angry Notes is hosted on Curseforge (https://www.curseforge.com/wow/addons/angry-notes). Maybe as a fall back, if no ID's are present, do a textual search based on Title (without web colors).

Yeah, so right now i am using https://addons-ecs.forgesvc.net/api/v2/addon/2382 for curse, where 2382 is an id found in the .toc file. That API, as far as i know, only works with that API. However later I would make sense to have a fallback solution with another API where i can search for a addon by slug/name.

from ajour.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.