Comments (8)
Hi Cristiano, you too!
For now I'll suggest to add a partial or complete docstring if you think it would help with comprehending the function. I'll have a better idea once I see these functions in the PR.
from scikit-spatial.
I am interested as well in having a best fit classmethod for the cylinder class. I studied the algorithm reported by Eberly and I hope to open a PR for that as soon as possible. Thanks for sharing the link above!
from scikit-spatial.
Hi @ajhynes7!
I hope everything's fine.
I discovered this Python repo by xingjiepan that implements David Eberly's algorithm for the best-fit cylinder (as an exercise, I have written this object-oriented implementation of xingjiepan's repo).
- I was thinking to re-implement all the logic directly into scikit-spatial. Does it sound good to you?
- The SciPy
minimize
function is required. Is it ok for you to have SciPy as an additional scikit-spatial's dependency?
from scikit-spatial.
Hi @CristianoPizzamiglio, sure you can go ahead and open a PR. But I'd like to keep supporting Python 3.7 for now, so I'm hoping you can use a SciPy version which is compatible with Python 3.7.
from scikit-spatial.
I'll make sure to preserve Python 3.7 compatibility.
A bunch of intermediate functions are required to run the algorithm. Where do you want to store them? Either as non-public functions within the cylinder
module or within a dedicated non-public module?
Let me know if you have any other suggestion, please. Thanks!
from scikit-spatial.
Since they're not being using by any other spatial objects, I think they should be private functions in the cylinder
module.
from scikit-spatial.
Sounds good, thanks! I'll open the PR soon.
from scikit-spatial.
Hi @ajhynes7 , happy 2023!
Should non-public functions have a complete docstring (parameters and returns)? The non-public functions in cylinder.py
have a partial docstring (e.g. _intersect_line_with_finite_cylinder
).
Thanks.
from scikit-spatial.
Related Issues (20)
- [enhancement] Signed Area - Shoelace Formula HOT 4
- [enhancement] Projection of a line onto a plane. HOT 2
- Slicing the Vector HOT 2
- Mesh for cylinders has wrong radius if not axis-aligned. HOT 2
- Faster Line.best_fit with scipy.sparse.linalg.svds HOT 4
- Value range for fitted plane is not right HOT 6
- Add object for line segment (closed line) HOT 3
- `angle_signed` for 3D Vectors HOT 2
- python3.6.x HOT 2
- intersection line are not complanar with line in plane HOT 13
- Method for computing the distance between two parallel planes? HOT 2
- Intersection between 2 Circles HOT 5
- Why raising ValueError instead of returning an empty list? HOT 3
- Vector from angle HOT 5
- [Feature request] defining a Circle() from 3 points HOT 12
- 2D geometry problem: fillet two curves HOT 1
- AttributeError: 'LineSegment' object has no attribute 'plotter' HOT 3
- `Line.distance_line` bug? HOT 3
- `Ellipse`/`Ellipsoid` classes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scikit-spatial.