Giter Club home page Giter Club logo

Comments (6)

ajeetdsouza avatar ajeetdsouza commented on May 12, 2024

I did consider this, but it comes with problems:

  • zoxide query sometimes needs to print other things to stdout, such as in the case of invalid usage, or passing the --help flag. This could result in strange behaviour if you're using a naive code $(zq <keywords>) command.
  • If there is any error while performing the query (eg. no match found), we print an error message to stderr, but nothing to stdout. Here, too, this may cause confusing behaviour.

Currently, the "query: " prefix allows us to keep the z function logic rather straightforward - it saves the output of zoxide, and if it starts with "query: ", it cds into it.

However, this is a very valid usecase, and is one that I too would love to see zoxide fulfill - so do tell me if you have any ideas about how to solve this!

from zoxide.

Emerentius avatar Emerentius commented on May 12, 2024

An alternative would be to offer a utility that would execute a given command with the results of a zoxide query interpolated in certain places, for example:
zoxide execute code {<keyword>...} (alias: ze)

That gives you control over the entire command and you can skip execution if an error occurs. Things tend to get a bit complicated when you have multiple utilities with this behaviour (e.g. rust-parallel, fd with it's --exec option) that call each other as you now have to escape the special syntax for each, possibly multiple times. I can't estimate how much of a problem that would be as I don't a usecase in mind that would require that.

Personally, I'd have no issue with using the zq command optimistically with the occasional confusion. Shell environments don't tend to have good fallback behaviour in general, so you're keeping yourself to a much higher standard than most, especially in the case where someone passes --help but tries to use the output as a path. I certainly don't intend to use this in combination with dangerous commands like rm -rf.

I can't say much about the complexity of the implementation as I'm not familiar with the internals.

from zoxide.

ajeetdsouza avatar ajeetdsouza commented on May 12, 2024

You make a fair point, I will work on this.

from zoxide.

ajeetdsouza avatar ajeetdsouza commented on May 12, 2024

I've added this in d3e49bd, it will be released with v0.3.1. Thanks!

from zoxide.

Emerentius avatar Emerentius commented on May 12, 2024

Thanks a lot!

As an aside, I'd wanted to have a way to navigate different paths with less typing for a long time before you posted about this tool on reddit. I just want to thank you for that.
Anything I would have built wouldn't have been nearly as useful as this. I realize it's inspired by other projects, but I couldn't have trusted a large shell codebase and not having to install lua makes setup easier as well. That's useful cause you can bet I'm going to install this on any PC and server of mine.

from zoxide.

ajeetdsouza avatar ajeetdsouza commented on May 12, 2024

Thank you, that means a lot!

from zoxide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.