Giter Club home page Giter Club logo

Comments (2)

ajdawson avatar ajdawson commented on July 28, 2024

This test looks wrong to me, I don't think the .all() should be there. You'd know more about comparing xarray coordinates than me, what is the best way to write this? I don't really use xarray much, and I implemented this whilst still learning how xarray works, errors and areas for improvement are inevitable.

from windspharm.

shoyer avatar shoyer commented on July 28, 2024

I think this is actually a pretty reasonable way to compare coordinates. And, if my guess is correct, this is actually a subtle NumPy bug/issue: arrays of different length compare as False instead of raising TypeError when compared.

I would simply replace (uc == vc).all() with np.all(uc == vc). That should fix the bool issue.

from windspharm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.