Remove "tabs" permission about sponsorblock HOT 20 CLOSED

Does this interfere with content scripts running in tabs that aren't the active tab. If not, then yes, that's a great idea to switch.

If you are up to it, feel free to make a PR :)

from sponsorblock.

Does this interfere with content scripts running in tabs that aren't the active tab.

No, content scripts continue running even if the tab is not active.

However, the patch will be rather large because this extension popup.js function runThePopup() uses a lot of code like this:

  chrome.tabs.query({
    active: true,
    currentWindow: true
  }, tabs => {
    chrome.tabs.sendMessage(
      tabs[0].id,
      {message: '...'},

It all needs to be rewrtten with activeTab instead.

from sponsorblock.

activeTab only seems to work when certain actions are taken and until the user navigates to a different origin.
This would work if you had a pageAction setup that you could click to invoke the extension
https://developer.chrome.com/extensions/pageAction
https://developer.chrome.com/extensions/activeTab#invoking-activeTab

from sponsorblock.

@officialnoob

activeTab can track your history

Yes, but only for pages that you explicitly envoke the extension on via browserAction or via a context menu. It has a much narrower scope than tabs. Currently, you use chrome.tabs.onActivated, which notifies you of all tab changes, even not related to YouTube (so, in theory, you could record all history including navigations and even just tab changes).

from sponsorblock.

activeTab tracking would only affect places where its been invoked

from sponsorblock.

I think Tab messaging should still work
As long as the extension gets invoked somehow

from sponsorblock.

@officialnoob

activeTab only seems to work when certain actions are taken and until the user navigates to a different origin.

Exactly.

This would work if you had a pageAction setup that you could click to invoke the extension

Yes, when you click the extension icon you trigger that pageAction and it can query the currently active tab to display the relevant info.

from sponsorblock.

So are people going to click a pageAction every time they visit youtube
Also how are embedded videos going to work?

from sponsorblock.

So are people going to click a pageAction every time they visit youtube

No, you trigger pageAction when you open the popup by clicking the extension icon. You use pageAction only to figure out what the current tab is to populate the popup with the proper info (if you have multiple pages open with multiple YouTube videos).

Also how are embedded videos going to work?

They are controlled by content scripts. Since videos are either on youtube.com or are iframes of it, they get injected with content scripts.

This way, if you open a page example.com that has an embedded video, the extension does not interact with example.com -- only with embedded YouTube frame. Now, if the user clicks on the extension icon, he/she grants temporary permission (pageAction) and thus the popup can interact with the page to display the relevant information.

from sponsorblock.

"when you open the popup by clicking the extension icon" so you do have to or it will not be in effect at the moment even submitting a video not just skipping you dont need to use the popup

The content script running on the host website is isolated from youtube.com by the iframe and should not be able to control it

https://discourse.mozilla.org/t/activetab-permission-does-not-include-iframes-in-current-tab/29084

from sponsorblock.

Hmm, this would require a significant rewrite after thinking about it. At the moment background.js is communicating with the content scripts to tell them when a new video is loaded. This would have to be changed to the content scripts using the on hashed changed function (which is probably a better way anyway).

Then, everything can be handled by the content script except for actions invoked by the popup.

The popup could save a variable right after being opened of the current tab and use that to communicate any time a button clicked (unless I'm misunderstanding).

If the plan to make the popup be only for global settings, then the active tab permission won't even be needed.

from sponsorblock.

I think the best way to solve this is just to make the popup not interact with the tabs at all and just act as a status page (showing how much you have contributed) and a global settings page.

from sponsorblock.

@ajayyy have you seen my message? I think the problem is valid

from sponsorblock.

@officialnoob

"when you open the popup by clicking the extension icon" so you do have to or it will not be in effect at the moment even submitting a video not just skipping you dont need to use the popup

I'm not sure what your question is.

@ajayyy

Hmm, this would require a significant rewrite after thinking about it.

Yes, it would because (currently) the extension uses a lot of chrome.tabs. I do not think this is a good solution because it does not work on pages other than YouTube pages with individual videos, where you already have a much better (in my opinion) option of opening popup in the sidebar. As it stands, current popup UI is mostly useless for my use cases:

• it does not work on any pages other than individual YouTube video page
• on individual YouTube video page, I would rather use the persistently open sidebar.

I think the best way to solve this is just to make the popup not interact with the tabs at all and just act as a status page (showing how much you have contributed) and a global settings page.

We should be asking a question "what is the best UI for the user" and not "what is easy to implement". The problem is, the first question is much harder than the second one.

from sponsorblock.

@ajayyy Implementing this will require significant code reorganization, so there is no point in stating on it before #89 gets merged.

from sponsorblock.

@bershanskiy I was trying to tell you about a problem if you want to use the URL, title, favicon url that you get with the extra permission you will need a action from the user which in an iframe may not be possible Im not sure why you even need activeTab messaging still works anyway

from sponsorblock.

Made a PR as this seems simple to add: #90

from sponsorblock.

why you even need activeTab

I meant that you do not need tabs and that you can use activeTab in all circumstances you would use tabs. E.g., it is sufficient for figuring out what to display on the popup, even for pages with embeded videos.
This is more of a future-proofing for cases when the user opens popup on pages with embedded videos (not YouTube itself). Currently, the extension simply does not allow the user to fine-tune ad times for embedded videos: the popup does not work and there is no side menu.

from sponsorblock.

Is sponsor submission really necessary for embeds anyway? Only skipping is needed I'd think.

from sponsorblock.

Well I think activeTab will not be needed as the URL of a tab is not needed only the video id
what do you mean by "even for pages with embedded videos." as I said If the extra stuff from that permission is needed there is no way to click a page action when its in a iframe... the only thing used from the URL is the video id and that can be sheared anyway

from sponsorblock.