Comments (11)
NDevTK
commented on May 22, 2024
1
Its done embedded videos are supported (using the button on the player).
I think the global popup would be better as settings.
from sponsorblock.
NDevTK
commented on May 22, 2024
Could I have a go?
from sponsorblock.
ajayyy
commented on May 22, 2024
Go for it :)
from sponsorblock.
NDevTK
commented on May 22, 2024
iframe communication problem
Options:
- Add button for popup to youtube player
- Add API that the popup can use (Would need way to select video)
from sponsorblock.
NDevTK
commented on May 22, 2024
I think this can be closed as option 1
from sponsorblock.
ajayyy
commented on May 22, 2024
Yea, option 1. Maybe add a message to the popup saying that it only works on YouTube.
from sponsorblock.
NDevTK
commented on May 22, 2024
Thats not to do with this issue please close it only has permission for youtube.com anyway
from sponsorblock.
ajayyy
commented on May 22, 2024
You want to be unassigned?
from sponsorblock.
ajayyy
commented on May 22, 2024
Which pull request?
from sponsorblock.
NDevTK
commented on May 22, 2024
I think you added support when you added the button to the player
from sponsorblock.
ajayyy
commented on May 22, 2024
It's not working yet, but I'm going to do this now. I just have to change
the way the notice works and change the url parsing code.
…On Thu, Aug 1, 2019, 5:56 AM Official Noob, ***@***.***> wrote:
I think you added support when you added the button to the player
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=ADAZV4H6EE4Y6MMXSP4IKSLQCKXNTA5CNFSM4IHHAFAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3KBKYQ#issuecomment-517215586>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADAZV4G7I2YAIW4XHSFQW7LQCKXNTANCNFSM4IHHAFAA>
.
from sponsorblock.
Related Issues (20)
- [Feature request] Show SponsorBlock on any video HOT 1
- [Feature] See your submitted segments and filter by SponsorBlock Marker in Backup/Restore HOT 1
- 5.5.9 - very high cpu usage, youtube tabs laggy and non-responsive HOT 9
- Feature request: {Synergy with HARPA AI | integrate AI in SponsorBlock} to automate time range detection HOT 1
- TLS Issues on sponsor.ajay.app when using IPv6? HOT 2
- 502/504 error on particular video HOT 5
- Misspelled IOS app yattee in wiki HOT 1
- Video rotates from landscape to portrait Firefox Android HOT 1
- [Firefox] Not working at all, popup is also blank HOT 1
- Sponsorblock not working on Firefox - A connection error has occurred. Error code: 504 HOT 2
- You have to check segments multiple times before it lets you upload
- [feature] "skip once" option for segment types HOT 1
- error code 504 HOT 17
- "No youtube video found" error. HOT 4
- Connection issue: Error 503/504 HOT 1
- API returning 502. HOT 1
- 'Preview' submission button should ignore submitter's personal preference, if set to 'Manual', 'Show' or 'Disabled', so that intended Skip can be correctly previewed. HOT 2
- Option for Light/White theme. HOT 3
- Feature Request: Non-Youtube Content Spoilers HOT 1
- userscript version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sponsorblock.