storing the build date inside firmware about airspyone_firmware HOT 5 CLOSED

Nice fix, I will apply it and check all is ok

from airspyone_firmware.

Done thanks for your contribution

from airspyone_firmware.

In case there is any problem with:
print '#define AIRSPY_FW_CHECKIN_DATE "' + git.show(['--pretty=format:%ai']).partition(' ')[0] + '"'
It can be replaced by:
print '#define AIRSPY_FW_CHECKIN_DATE "' + git.log('-1','--format=%ai').partition(' ')[0] + '"'
Which is probably easier to understand what it is doing

from airspyone_firmware.

I have tested it with success but any feedback is welcome and if some
configuration have problems we could use
print '#define AIRSPY_FW_CHECKIN_DATE "' + git.log(['-1
--format=%cd']).partition(' ')[0] + '"'
(if that solve problems)

On 6 September 2015 at 13:24, itsbert [email protected] wrote:

In case there is any problem with:
print '#define AIRSPY_FW_CHECKIN_DATE "' +
git.show(['--pretty=format:%ai']).partition(' ')[0] + '"'
It can be replaced by:
print '#define AIRSPY_FW_CHECKIN_DATE "' + git.log(['-1
--format=%cd']).partition(' ')[0] + '"'

—
Reply to this email directly or view it on GitHub
#13 (comment).

from airspyone_firmware.

No, no problem here. it works for me. I just think that it is slightly less obtuse and more easily understood, but the name of the define, AIRSPY_FW_CHECKIN_DATE, helps to make things clear.

EDIT:
Actually there may be a problem, when I run "git show --pretty=format:%ai" in a local clone of another git that I have (liquid-dsp), I see the following:
$ git show --pretty=format:%ai
2015-07-21 18:49:53 -0400
But when I run it in airspy/firmware I see the following:
$ git show --pretty=format:%ai
2015-09-06 12:09:36 +0200
diff --git a/airspy_m0/airspy_m0.c b/airspy_m0/airspy_m0.c
index 805a829..9d8a7e6 100644
--- a/airspy_m0/airspy_m0.c
+++ b/airspy_m0/airspy_m0.c
@@ -74,7 +74,7 @@ volatile airspy_mcore_t set_packing = (airspy_mcore_t *)((&cm0_data_share)+2);
uint8_t const usb_bulk_buffer = (uint8_t*)0x20004000;
uint8_t spiflash_buffer[W25Q80BV_PAGE_LEN];
-char version_string[] = VERSION_STRING " " AIRSPY_FW_GIT_TAG " "AIRSPY_FW_BUILD_DATE;
+char version_string[] = VERSION_STRING " " AIRSPY_FW_GIT_TAG " "AIRSPY_FW_CHECKIN_DATE;^M
uint8_t version_string_strlen = sizeof(version_string);
typedef struct {
diff --git a/scripts/airspy_fw-version.py b/scripts/airspy_fw-version.py
index 5442580..104592a 100755
--- a/scripts/airspy_fw-version.py
+++ b/scripts/airspy_fw-version.py
@@ -13,7 +13,7 @@ if len(args)==1:
sys.stdout = open(args[0], 'w')
git=Repo(search_parent_directories=True).git
print '#define AIRSPY_FW_GIT_TAG "' + git.describe(tags=True,always=True,dirty=True,long=True) + '"'
- print '#define AIRSPY_FW_BUILD_DATE "' + date.today().isoformat() + '"'
+ print '#define AIRSPY_FW_CHECKIN_DATE "' + git.show(['--pretty=format:%ai']).partition(' ')[0] + '"'
else:
parser.print_help()
sys.exit(1)

I haven't used git from python so it's behaviour may be different than the command that I'm using. :

I also edited the post that I made to use "%ai" instead of "%cd"

from airspyone_firmware.