Change major usages of "Subsonic" about airsonic HOT 7 CLOSED

Comment by csobsidian
Sunday May 08, 2016 at 01:59 GMT

As a note, I've started going through and finding these items. Obviously, they are quite numerous, but some are not as clear cut as they might seem. For instance, there are references to "Subsonic Premium" which have no context here. I think it would be wise to not touch any items that may be later slated for removal. That will make them easier to find. Thoughts?

from airsonic.

Comment by EugeneKay
Sunday May 08, 2016 at 02:14 GMT

I agree; let's leave "Subsonic Premium" references alone. Removing those(and squashing the remnants of the licensing code) are best left handled in a separate Issue further down the line.

Mostly, I want to make it clear that Libresonic is not the same software as Subsonic.

from airsonic.

Comment by csobsidian
Monday May 09, 2016 at 01:30 GMT

Okay. I actually had some time today and am working through these now with the rebased code. A couple of more notes on things I am not changing at this time:

• Copyright notices that contain info about Subsonic. A new issue should be started (and dedicated) to tackling these.
• the getBrand() function of the SettingsService as I do not know how this will affect other operations.

from airsonic.

Comment by csobsidian
Monday May 09, 2016 at 01:43 GMT

There are also a large number of references to subsonic website addresses in the localization files.

from airsonic.

Comment by csobsidian
Monday May 09, 2016 at 02:44 GMT

Subsonic logos exist in the webapp for each theme (i.e. logo.png) and there is also a large format logo: subsonic-512.png.

from airsonic.

Comment by csobsidian
Monday May 09, 2016 at 12:10 GMT

Do we want to put in a placeholder logo for these images until issue #43 is resolved and we have a new logo?

from airsonic.

Comment by EugeneKay
Tuesday May 10, 2016 at 03:01 GMT

Merged #59.

from airsonic.