Giter Club home page Giter Club logo

Comments (1)

kyrylo avatar kyrylo commented on May 20, 2024

Unfortunately, we will have to stick to the current API because changing it will break user code.

Golang doesn't support default struct values and the way we currently recommend initializing a config is like this:

opt := &gobrake.NotifierOptions{
	DisableCodeHunks: true,
}

If we make the renaming, then we no longer will be collecting code hunks by default. Users will have to enable the option explicitly in the config to keep using code hunks:

opt := &gobrake.NotifierOptions{
	CodeHunks: true,
}

However, we want to collect that by default. So the proper solution is to recommend initializing the config via our constructor method instead. Something like this:

type NotifierOptions struct {
	CodeHunks bool
}

func NewNotifierOptions() *NotifierOptions {
	return &NotifierOptions{
		CodeHunks: true,
	}
}

// ------

opt := gobrake.NewNotifierOptions()

Alternatively, we can make it a reference to bool:

type NotifierOptions struct {
	CodeHunks *bool
}

// ---

f := &false
opt := NotifierOptions{
	CodeHunks: &f,
}

But that looks ugly as an API.

from gobrake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.