Comments (1)
Unfortunately, we will have to stick to the current API because changing it will break user code.
Golang doesn't support default struct values and the way we currently recommend initializing a config is like this:
opt := &gobrake.NotifierOptions{
DisableCodeHunks: true,
}
If we make the renaming, then we no longer will be collecting code hunks by default. Users will have to enable the option explicitly in the config to keep using code hunks:
opt := &gobrake.NotifierOptions{
CodeHunks: true,
}
However, we want to collect that by default. So the proper solution is to recommend initializing the config via our constructor method instead. Something like this:
type NotifierOptions struct {
CodeHunks bool
}
func NewNotifierOptions() *NotifierOptions {
return &NotifierOptions{
CodeHunks: true,
}
}
// ------
opt := gobrake.NewNotifierOptions()
Alternatively, we can make it a reference to bool:
type NotifierOptions struct {
CodeHunks *bool
}
// ---
f := &false
opt := NotifierOptions{
CodeHunks: &f,
}
But that looks ugly as an API.
from gobrake.
Related Issues (20)
- Intermittent failures in the test suite HOT 1
- Use fixtures for code hunk testing
- API Authentication if being embedded in a client-side application? HOT 1
- Make it possible to run tests without an internet connection
- Bug: `gobrake: span="http.client" is already finished` HOT 3
- Gobrake v5 is not respecting the HTTPClient HOT 3
- Remote configuration: write config.json to a writeable place
- dumpConfig failed: no such file or directory HOT 5
- Cant install gin HOT 5
- Make *Notifier.Notify return first argument (error message) HOT 1
- Using 5.5.1 is still reported as 5.4.0
- Auto-notify when logging at the error level HOT 3
- Airbrake on low internet connectivity HOT 2
- remote_config.go fetchConfig failed - AccessDenied error HOT 2
- Fix HIGH severity level vulnerability `CVE-2021-23772` HOT 4
- segmentation fault when sending notice HOT 2
- zapbrake include fields in the Airbrake notice
- gobrake v5.6.1 flagged out of date on airbrake.io?
- setNoticeBacklog meant to never terminate?
- Cert Error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gobrake.