When updating value prop onChange is triggered about rheostat HOT 13 CLOSED

i'll create an example so we have something to talk about, give me a bit.

from rheostat.

"on change" suggests to me that it should fire whenever there's been any change at all; the source of that change is irrelevant.

from rheostat.

Well maybe, but that's not how controlled input components work in react.. if they did we'd get into infinite loops by default wouldn't we? 😬

from rheostat.

A controlled input wouldn't have the value change except via user action; can you provide a repro case where you're getting onChange otherwise?

from rheostat.

Sure I'll make a webpack bin real quick (...in a few hours, train is just getting into work, sorry!)

Also - I'm actually changing the value via user interaction (then updating state onChange), as well as updating the value programatically on a button press. Maybe that use case wasn't initially considered?

from rheostat.

"on a button press" is as a result of user interaction, why wouldn't that trigger onChange?

from rheostat.

@ljharb hey, made an example repo -> https://github.com/madou/rheostat-double-onchange

wanted to use webpack bin but it isn't working atm.

from the example - i would have thought rheostat wouldn't call onchange if i set the value outside of it. but it's calling it. whats your thoughts?

from rheostat.

Yup, it looks like onChange is called whenever values change. The documentation states that onChange is called when the values are "committed" which happens by drag, click, keyboard input, and props change.

We should maybe not do it when props change to your point of not having it trigger an infinite loop but I think that line is there for a reason.

Perhaps what we need is an event that fires only when the slider is changed in a non-programmatic way.

from rheostat.

hey! maybe.

i think the default expectation (well myself at least, haha) using controlled input components is it only gets triggered from the component itself trying to change. so i don't think it would be completely left field to make it do that.

breaking change though.

from rheostat.

@Madou Yes, I was expecting the same behavior as controlled inputs and it triggered infinite loop while setting values state programmatically.
I agree with the @goatslacker, we can add an event that only fires when the user interacts with the slider.

from rheostat.

Since onChange is called even when the props change, had to do a workaround as mentioned by @Madou. I second @goatslacker for adding an event that fires only when slider is changed by the user.

from rheostat.

I'm seeing the onChange getting called when the min/max props changing, but not the values. Perhaps the onChange should only call if values have changed from being outside min/max range 🤔

from rheostat.

We've also been dealing with this causing infinite loops, ended with a nextChangeIsReal flag to implement @Madou 's suggestion.
It feels like an unexpected thing for the component do to compared to other controlled components

from rheostat.