Critical dependency: the request of a dependency is an expression about babel-plugin-dynamic-import-node HOT 9 CLOSED

@wmm387 @KnisterPeter this plugin is for node, not for webpack - we have https://github.com/airbnb/babel-plugin-dynamic-import-webpack for webpack 1 and 2, and webpack 3+ understands this syntax natively.

from babel-plugin-dynamic-import-node.

I also have this problem.

from babel-plugin-dynamic-import-node.

Me too. Downgrading fixes this.

from babel-plugin-dynamic-import-node.

Same here, should be downgraded to 2.3.0

from babel-plugin-dynamic-import-node.

The created output here is something like this:

Promise.resolve('prefix-${var}').then(s => require(s))

If this is check by webpack, it results in unmatched dynamic imports.
Webpack could understand require('prefix-${var}') but not require(s)

The fix for #84 need to be reverted and fixed in another way.

from babel-plugin-dynamic-import-node.

cc @nicolo-ribaudo we may have to revert to the original, but still evaluate the result twice so as to evaluate it sync?

from babel-plugin-dynamic-import-node.

@ljharb Thanks for the hint

from babel-plugin-dynamic-import-node.

cc @nicolo-ribaudo we may have to revert to the original, but still evaluate the result twice so as to evaluate it sync?

Evaluating twice is worse than evaluating asynchronously. Also, it would bring back the bug that originally led to that PR (yield or await inside import arguments).

If the dynamic import argument is a single StringLiteral, we could transpile it to

Promise.resolve().then(s => require("./module"))

in more complex cases where it would be observable, I think that it is better to do the correct thing rather than trying to adapt the output to webpack, which doesn't need this plugin in the first place.

from babel-plugin-dynamic-import-node.

That seems totally reasonable.

from babel-plugin-dynamic-import-node.