Giter Club home page Giter Club logo

Comments (6)

ain avatar ain commented on May 19, 2024 1

@fvoordeckers thanks for the ticket!

For now the default behaviour has been retained, mainly due to legacy support. Nevertheless, this will change in 2.0.0.

Please see path-designated close for more info.

from smartbanner.js.

fvoordeckers avatar fvoordeckers commented on May 19, 2024

By adding the path to the cookie string this issue might be solved.

from smartbanner.js.

ain avatar ain commented on May 19, 2024

Thanks for the report. This definitely deserves some investigation.

from smartbanner.js.

fvoordeckers avatar fvoordeckers commented on May 19, 2024

@ain thanks for picking this one up in the next release

from smartbanner.js.

fvoordeckers avatar fvoordeckers commented on May 19, 2024

@ain just letting you know the path-designated close doesn't solve this issue (also changing the default valui in v2.0.0 will not solve it).

The problem is that the cookie doesn't have a specified path and will therefore fallback to the current path. All the pages under the same path will act correctly, all pages on another path will show the banner again because the cookie path is different.

from smartbanner.js.

ain avatar ain commented on May 19, 2024

It solves a problem for all paths if set to /. Default setting in 2.0.0 would disable showing smartbanner across the site.

from smartbanner.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.