Comments (3)
By the way, if you use request.validate_response(rack_response)
without passing raise_error: true
you get an object where you can get all details including the response body. Somehing like:
response = Rack::Response[*app.call(env)]
request = Rack::Request.new(env)
validated = definition.validate_response(request, response)
unless validated.valid?
validated.body # => parsed response body
validated.error # => Failure instance
validated.error.errors.map(&:message)
end
from openapi_first.
Hi. I think it makes sense to add more details to exceptions.
I think it would be best to add ResponseInvalidError#errors
or ResponseInvalidError#failure.errors
to return an array of error objects (Schema::ValidationError
) coming from the schema validation result and use that to get detailed information about what went wrong during validation without leaking too many details of your actual response body.
Making the actual response available on the exception makes sense to me as well for debugging, but I would not use that to log the response body.
from openapi_first.
By the way, if you use
request.validate_response(rack_response)
without passingraise_error: true
you get an object where you can get all details including the response body. Somehing like:
Thanks! That seems to work nice.
Logging at this point is just because some minor errors (mostly missing null being allowed) are still too abundant.
Once i got the bulk going without errors i will switch over to send validation problems to Sentry and later have request and response validation active all the time on our public development server (opposed to just on my local dev machine).
from openapi_first.
Related Issues (20)
- 415 Unsupported Media Type when posting form data from Postman HOT 4
- Capture names affects finding definitions for nested routes HOT 4
- Is anybody using the standalong mode (OpenapiFirst.app) HOT 1
- Access operation level or top-level `security` object HOT 1
- Request header validation
- Cookie request parameter validation HOT 1
- Response header validation
- The purpose of hanami in this gem? HOT 10
- Manual request/response validation HOT 6
- v1.0.0.beta5 release not available via rubygems.org HOT 7
- Manual response validation breaking change in 1.0.0->1.1.0 upgrade HOT 2
- Spec has a binary field - openapi-first failing with exception trying to get the :tempfile HOT 13
- Don't read uploaded files to validate "binary" fields
- validation of string format uri wrongly fails with relative pathes HOT 5
- Parse error for kebab-case URL parameters HOT 4
- rails 6 - error when parsing non-array response body HOT 11
- Can't seem to get rid of a response validation error with format: byte, nullable true HOT 4
- Builtin middlewares trigger deprecation warnings. HOT 4
- Validate OpenAPI file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openapi_first.