Giter Club home page Giter Club logo

Comments (3)

ahx avatar ahx commented on June 2, 2024 1

By the way, if you use request.validate_response(rack_response) without passing raise_error: true you get an object where you can get all details including the response body. Somehing like:

response = Rack::Response[*app.call(env)]
request = Rack::Request.new(env)
validated = definition.validate_response(request, response)
unless validated.valid?
  validated.body # => parsed response body
  validated.error # => Failure instance
  validated.error.errors.map(&:message)
end

from openapi_first.

ahx avatar ahx commented on June 2, 2024

Hi. I think it makes sense to add more details to exceptions.
I think it would be best to add ResponseInvalidError#errors or ResponseInvalidError#failure.errors to return an array of error objects (Schema::ValidationError) coming from the schema validation result and use that to get detailed information about what went wrong during validation without leaking too many details of your actual response body.

Making the actual response available on the exception makes sense to me as well for debugging, but I would not use that to log the response body.

from openapi_first.

neongrau avatar neongrau commented on June 2, 2024

By the way, if you use request.validate_response(rack_response) without passing raise_error: true you get an object where you can get all details including the response body. Somehing like:

Thanks! That seems to work nice.

Logging at this point is just because some minor errors (mostly missing null being allowed) are still too abundant.

Once i got the bulk going without errors i will switch over to send validation problems to Sentry and later have request and response validation active all the time on our public development server (opposed to just on my local dev machine).

from openapi_first.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.