Windows support about ahrq-cds-connect-pain-management-summary HOT 25 CLOSED

We expect it to work in Windows, but we have not recently tested it in Windows. I believe others who use Windows have had success. I just tested a clean clone on my Mac to make sure there isn't some larger issue at play. Unfortunately, I don't have a Windows machine easily available to me right now...

A few things to check:

• Are you using Node 0.12.x?
• Is your yarn up to date?
• Did you use yarn to install the dependencies? (using npm is untested).

from ahrq-cds-connect-pain-management-summary.

We made changes in our branch to address this, see uwcirg@9ef1881 . Checking w/ others here to see whether any of that commit introduces dependencies novel to our branch...

from ahrq-cds-connect-pain-management-summary.

@achen2401 says that these changes don't add dependencies that are novel to our branch. @ivan-c fyi

from ahrq-cds-connect-pain-management-summary.

Thanks @mcjustin... Looking through that commit, however, I'm having trouble seeing what would affect that error with .rescriptsrc.js... Most of the changes you applied seem like they would happen well after rescript has been executed. Do you know which specific bit addressed the issue Bryn is asking about?

from ahrq-cds-connect-pain-management-summary.

@cmoesel At least for us, the error was specific to launch.js so polyfills are imported specifically in that file and the error went away after that for us. I don't know if that is the same issue that Bryan is experiencing.

from ahrq-cds-connect-pain-management-summary.

Ah yes, I'm not getting to that point, the error is preventing the launch entry from being added. And I confirmed by taking a local clone of the referenced branch and I still get the "Could not add launch entry" error.

I also note that I got this from building on that fork:

  `@babel/polyfill` is deprecated. Please, use required parts of `core-js`
  and `regenerator-runtime/runtime` separately

Not sure if that's a known issue, but wanted to note it in case it's helpful.

from ahrq-cds-connect-pain-management-summary.

And @cmoesel , thank you for the suggestions, I verified my node is v12.14.1, and I didn't have yarn yet, so that was a fresh install of latest, and I did use yarn to install the dependencies locally.

from ahrq-cds-connect-pain-management-summary.

I also note that I got this from building on that fork:

  `@babel/polyfill` is deprecated. Please, use required parts of `core-js`
  and `regenerator-runtime/runtime` separately

Not sure if that's a known issue, but wanted to note it in case it's helpful.

Thanks @brynrhodes I will make the necessary fixes.

from ahrq-cds-connect-pain-management-summary.

@brynrhodes -- what is the full error you got? You posted only the first line, but I expect there is more to it?

Another thing I've seen before is strangeness related to what shell you are using. I think on Windows there are a few choices. Maybe try it in a different shell?

Most of us on my team have Mac. The one guy who has Windows is on vacation this week! :-/

from ahrq-cds-connect-pain-management-summary.

@cmoesel , here's the full log

yarn run v1.22.4
$ rescripts start
Cannot add launch.js to entry. Unexpected starting value for entry: [
  'C:\\Users\\Bryn\\Documents\\Src\\AHRQ\\AHRQ-CDS-Connect-PAIN-MANAGEMENT-SUMMARY\\node_modules\\react-dev-utils\\webpackHotDevClient.js',
  'C:\\Users\\Bryn\\Documents\\Src\\AHRQ\\AHRQ-CDS-Connect-PAIN-MANAGEMENT-SUMMARY\\src\\index.js'
]
i ｢wds｣: Project is running at http://10.0.75.1/
i ｢wds｣: webpack output is served from
i ｢wds｣: Content not from webpack is served from C:\Users\Bryn\Documents\Src\AHRQ\AHRQ-CDS-Connect-PAIN-MANAGEMENT-SUMMARY\public
i ｢wds｣: 404s will fallback to /

from ahrq-cds-connect-pain-management-summary.

I'm using the default command shell, I'll try with powershell...

from ahrq-cds-connect-pain-management-summary.

FYI, running in powershell gave exactly the same output

from ahrq-cds-connect-pain-management-summary.

Oh. That full error definitely helps. It looks like an issue w/ file separators (Windows vs Mac). I don't know how this hasn't been an issue before unless something happened that changed how the contents of that array are represented. Anyway, I think I can fix that. Standby and I'll try to have a branch ready in the next 30 minutes or so.

from ahrq-cds-connect-pain-management-summary.

@brynrhodes -- can you try the fix-rescript-windows branch to see if it fixes the issue?

from ahrq-cds-connect-pain-management-summary.

@cmoesel , thank you so much, different output, at this point:

yarn run v1.22.4
$ rescripts start
Cannot modify output filename. Unexpected starting value: static/js/bundle.js
i ｢wds｣: Project is running at http://10.0.75.1/
i ｢wds｣: webpack output is served from /
i ｢wds｣: Content not from webpack is served from C:\Users\Bryn\Documents\Src\AHRQ\AHRQ-CDS-Connect-PAIN-MANAGEMENT-SUMMARY\public
i ｢wds｣: 404s will fallback to /index.html
Starting the development server...

Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade`

  `@babel/polyfill` is deprecated. Please, use required parts of `core-js`
  and `regenerator-runtime/runtime` separately

Not sure whether that "cannot modify output file name" is relevant?

from ahrq-cds-connect-pain-management-summary.

It definitely gets further, I'm able to pick the patient, but it stalls there:

from ahrq-cds-connect-pain-management-summary.

Well that's annoying. Apparently React uses OS-specific path separators in some places and not in others. I was over-agressive in my application of OS-specific path separators. And I think that the blank screen is probably related to that error. I'm less concerned about caniuse-lite and @babel/polyfill right now.

I just pushed a new commit that I think will fix the issue for you. If I new the emoji code for crossed fingers, I would use it right now.

from ahrq-cds-connect-pain-management-summary.

You, sir, are a wizard! Totally worked:

(ninja)
Thank you so much!

from ahrq-cds-connect-pain-management-summary.

Finally. ;-)

I just uploaded our test R4 patient. Her name is Brenda Jackson. Here is a launch URL (for localhost:8000) that should work for you if you want to try it with Brenda: http://launch.smarthealthit.org/?auth_error=&fhir_version_1=r2&fhir_version_2=r4&iss=&launch_ehr=1&launch_url=http%3A%2F%2Flocalhost%3A8000%2Flaunch.html&patient=5c41cecf-cf81-434f-9da7-e24e5a99dbc2&prov_skip_auth=1&provider=&pt_skip_auth=1&public_key=&sb=&sde=&sim_ehr=1&token_lifetime=15&user_pt=

from ahrq-cds-connect-pain-management-summary.

Note that the DB resets at midnight, so tomorrow Brenda will (sadly) be gone. But the DSTU2 version of Brenda is always available, so there's that. (You can search for her by name).

You can also run yarn upload-test-patients from the root folder of this app and it will attempt to re-upload R4 Brenda (and other DSTU2 people) -- but it's not always successful due to some strangeness with how the SMART server handles HTTP PUT.

from ahrq-cds-connect-pain-management-summary.

Yes, that worked as expected, thank you!

The only question I have now is we are forked off of master; what is the timeline for this fix to be committed to the master branch?

from ahrq-cds-connect-pain-management-summary.

I don't like to merge without a code review. How about I get a code review on Monday and merge it in Monday as well. Does that work for you?

from ahrq-cds-connect-pain-management-summary.

Yes, absolutely, I'm just trying to get a sense for whether there's a release cycle (which would be fine, it would just mean we'd need to cherry pick the fix).

from ahrq-cds-connect-pain-management-summary.

No release cycle. At this point, we (AHRQ/MITRE) are only doing releases on an as-needed basis.

from ahrq-cds-connect-pain-management-summary.

@brynrhodes -- this fix is in master now. Let me know if you run into any issues.

from ahrq-cds-connect-pain-management-summary.