Giter Club home page Giter Club logo

Comments (5)

mjambon avatar mjambon commented on August 23, 2024

I assume you mean atdgen -v file.atd. This produces file_v.mli and file_v.ml:

(* Auto-generated from "file.atd" *)


type json = Yojson.Safe.json

let validate_json = (
  Yojson.Safe.validate_json
)

This is the correct behavior. It's just that Yojson.Safe.validate_json doesn't exist. It seems to be the only thing that's missing.

The workaround (that I just found in our Esper codebase, yikes) is to create the following json module for yourself and reference it instead of Yojson.Safe:

include Yojson.Safe

let validate_json _ _ = None

from atd.

mjambon avatar mjambon commented on August 23, 2024

I added validate_json to Yojson.Safe and siblings in yojson 1.3.0. ocaml-community/yojson@v1.2.3...v1.3.0

I think the reason why I didn't do it earlier was that I was fearing a mutual dependency. There's actually no problem since Yojson.Safe.validate_json is polymorphic.

from atd.

mjambon avatar mjambon commented on August 23, 2024

opam submission in progress ocaml/opam-repository#5303

from atd.

mjambon avatar mjambon commented on August 23, 2024

From @vbmithr on December 17, 2015 4:7

Thanks. I relied on exactly the same workaround :)

from atd.

shonfeder avatar shonfeder commented on August 23, 2024

In case it helps future seekers: the fix to Yojson was removed, see ocaml-community/yojson#136. So, iiuc, extending the Yojson.Safe as per #97 (comment) is the way to do this now.

from atd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.