Append description of image about halkabox.js HOT 6 CLOSED

I'm impressed! Thanks for the quick turnaround.

The captions work great. The points you mentioned tested well in Safari, Chrome, Firefox and iOS Safari (single touch hides the caption and buttons, zooming works on mobile).

There is a slight difference in how the captions line up with the bottom of the image depending on whether the iOS Safari bottom bar is showing (see the following screenshots). Not sure if that's fixable:

An option to position the caption directly below the image (instead of at the bottom of the screen) would also be lovely, but it also works great without it.

Thanks again!

from halkabox.js.

@manouman yes you can add alt or title attributes but the script as of yet wont change it into caption in the lightbox overlay. but the alt and title attributes will be applied nonetheless according to the browser implemented specifications.

from halkabox.js.

Would love to see this caption feature added. Adding visible image credits to the lightbox is necessary for most of my projects.

from halkabox.js.

@ooloth @manouman

Thank you for your input. I have added the caption feature. Please visit the following link and test it and share your feedback. Thank you.

https://ahmednooor.github.io/halkaBox.js/testing

p.s. single touch will hide the caption and buttons. please test that too. and please see if browser based zooming works (pinching in and out) on mobile. thank you.

from halkabox.js.

@ooloth thanks a lot for the detailed test. the caption is position fixed to the bottom and have a semi opaque background that is why when the bottom bar of the safari appears, the screen height shortens and hence the caption moves over the image. Regarding "An option to position the caption directly below the image (instead of at the bottom of the screen)", if that is done then the height of the image will decrease relative to the height of the caption and i haven't added a custom zooming functionality that can work on desktop, yet. so this is not a viable option.
Once again thanks a lot for your input.

from halkabox.js.

Features added in version 1.0.0
https://github.com/ahmednooor/halkaBox.js/releases/tag/1.0.0

from halkabox.js.