Giter Club home page Giter Club logo

Comments (2)

agilgur5 avatar agilgur5 commented on August 15, 2024

Ah, poop, well that's a dumb mistake 😅 . Thanks for catching this and filing the issue @Venryx !

You probably meant this instead:

if (jsonify == null) { jsonify = true } // default to true like mobx-persist

Actually, I meant undefined, since if jsonify is not specified, it'll be undefined, not null. So that would look like:

if (typeof jsonify === 'undefined') { jsonify = true } // default to true like mobx-persist

At some point I just had jsonify = true as a default arg in the destructuring, and then once I wrote the somewhat complex (and later even more in #15) defaults logic for the storage config, I thought it would make sense to do all defaults outside of destructuring. That clearly invited some bugs 😖 .

=== undefined is meant to replicate how default args work, but I think I'll just make it a default arg instead to fix as I'm already using one for Transforms anyway and, as I found out during its implementation, default args make for better typings too.

from mst-persist.

agilgur5 avatar agilgur5 commented on August 15, 2024

Fix has been released in v0.1.2

from mst-persist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.