Comments (2)
Ah, poop, well that's a dumb mistake 😅 . Thanks for catching this and filing the issue @Venryx !
You probably meant this instead:
if (jsonify == null) { jsonify = true } // default to true like mobx-persist
Actually, I meant undefined
, since if jsonify
is not specified, it'll be undefined
, not null
. So that would look like:
if (typeof jsonify === 'undefined') { jsonify = true } // default to true like mobx-persist
At some point I just had jsonify = true
as a default arg in the destructuring, and then once I wrote the somewhat complex (and later even more in #15) defaults logic for the storage
config, I thought it would make sense to do all defaults outside of destructuring. That clearly invited some bugs 😖 .
=== undefined
is meant to replicate how default args work, but I think I'll just make it a default arg instead to fix as I'm already using one for Transforms anyway and, as I found out during its implementation, default args make for better typings too.
from mst-persist.
Fix has been released in v0.1.2
from mst-persist.
Related Issues (20)
- `storage` type should be more specific
- Add CI
- CJS export is missing __esModule - Code transpiled to CJS can't use default export HOT 3
- Docs should mention that mst-persist is compatible with redux-persist's Storage Engines
- When using AsyncLocalStorage, "Illegal invocation" error occurs HOT 3
- `persist` should return disposer
- [RFC] Transforms & Migrations (& Plugins?) HOT 2
- Initial State isn't merged -- undefined is not assignable to type HOT 3
- Persist changed value from `true` to `false` HOT 3
- Add Deep Whitelists & Blacklists HOT 5
- add expiration time? HOT 2
- Persist Array in React Native, empty string? -- can't repro HOT 3
- jest failing on react-scripts - needs a CJS build HOT 9
- Should you clear storage when changing your schema? HOT 2
- data not saved when using `blacklist` or `whitelist` -- can't repro HOT 1
- mst peerDep is outdated HOT 3
- Add tests HOT 2
- Add configurable merge strategies HOT 3
- Refactor to TypeScript / Add typings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mst-persist.